-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify time for DataUi queries #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for the friendly commits :)
) { | ||
match verbosity { | ||
UiVerbosity::Small | UiVerbosity::MaxHeight(_) => { | ||
ui.label("Rigid 3D transform").on_hover_ui(|ui| { | ||
self.data_ui(_ctx, ui, UiVerbosity::Large); | ||
self.data_ui(_ctx, ui, UiVerbosity::Large, _query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.data_ui(_ctx, ui, UiVerbosity::Large, _query); | |
self.data_ui(ctx, ui, UiVerbosity::Large, query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are arguments only used in recursion (as clippy reminded me friendly). Naming them like this quiets clippy, but perhaps an explicit silencing of clippy would be more instructive
arrow_component_ui(ctx, ui, &component_data, verbosity, query); | ||
} | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not delete all of this, that's the classic path isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I figure it's been done in that other PR.
Previously all time queries in
DataUi
was done on the current set time.Now the query time (and timeline) can be set by argument. This means we can now easily construct a ui to e.g. show some
DataPath
at some arbitrary time.This now allows the streams view (time panel) to show a nice preview of the entity or component being hovered
Probably best reviewed one commit at a time.
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)