Specify time for DataUi queries #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Jan 30, 2023
| ) { | ||
| match verbosity { | ||
| UiVerbosity::Small | UiVerbosity::MaxHeight(_) => { | ||
| ui.label("Rigid 3D transform").on_hover_ui(|ui| { | ||
| self.data_ui(_ctx, ui, UiVerbosity::Large); | ||
| self.data_ui(_ctx, ui, UiVerbosity::Large, _query); |
There was a problem hiding this comment.
Suggested change
| self.data_ui(_ctx, ui, UiVerbosity::Large, _query); | |
| self.data_ui(ctx, ui, UiVerbosity::Large, query); |
There was a problem hiding this comment.
These are arguments only used in recursion (as clippy reminded me friendly). Naming them like this quiets clippy, but perhaps an explicit silencing of clippy would be more instructive
| arrow_component_ui(ctx, ui, &component_data, verbosity, query); | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Why not delete all of this, that's the classic path isn't it?
There was a problem hiding this comment.
Oh, I figure it's been done in that other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all time queries in
DataUiwas done on the current set time.Now the query time (and timeline) can be set by argument. This means we can now easily construct a ui to e.g. show some
DataPathat some arbitrary time.This now allows the streams view (time panel) to show a nice preview of the entity or component being hovered
Probably best reviewed one commit at a time.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)