Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for switching to the re_int_histogram crate #984

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 30, 2023

This is a refactor that starts preparing for a switch to using the re_int_histogram crate for our streams panel data visualizations, which will in turn solve #619

In the meantime, this PR should lover our memory consumption slightly for when we have a lot of data points as it now only stores a usize count per time instead of the full MsgId.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@teh-cmc teh-cmc self-requested a review January 30, 2023 09:32
@emilk emilk merged commit e475843 into main Jan 30, 2023
@emilk emilk deleted the emilk/prepare-for-int-histogram branch January 30, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants