Hack depth offset in order to make objects not disappear #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the things here is great, but it solves the problem at hand. * smaller depth offset steps (experimented in tracking_hf & colmap with history on the image itself) * bypass far z culling completely (far away layered images will "loose" more and more layers, but they won't disappear) * limit image plane distance to not be too insane * ensure use of f32 depth buffer for more consistency in this whole mess (precision was essentially unspecified so far)
emilk
reviewed
Jan 30, 2023
emilk
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the things here is great, but it solves the problem at hand.
Fix of one of the issues in #880
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)