Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A building error on windows platform which caused by esmodule _… #584

Merged

Conversation

JinweiOS
Copy link
Contributor

When I join the work about traslating rescript-lang site to chinese here, I have found an error of building the site project. so I added some code to support unix-like and win32 system at the same time.

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryyppy ryyppy merged commit aab239e into rescript-association:master Nov 3, 2022
@JinweiOS JinweiOS changed the title fix: An building error on windows platform which caused by esmodule _… fix: A building error on windows platform which caused by esmodule _… Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants