GenType: removed support for @genType.as in type definitions, which has become unnecessary.
#6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
changed the title
@genType.as which has become unnecessary.@genType.as in type definitions, which has become unnecessary.
cristianoc
force-pushed
the
gentype_remove_rename
branch
from
da9a11f
to
53cd497
Compare
cknitt
reviewed
Mar 26, 2023
cknitt
reviewed
Mar 26, 2023
| @@ -43,6 +43,7 @@ test-all: test test-gentype | |||
|
|
|||
| reanalyze: | |||
| reanalyze.exe -set-exit-code -all-cmt _build/default/res_syntax -suppress res_syntax/testrunner | |||
| reanalyze.exe -set-exit-code -all-cmt _build/default/jscomp -suppress res_syntax/testrunner -exclude-paths jscomp/super_errors,jscomp/outcome_printer,jscomp/ounit_tests,jscomp/ml,jscomp/js_parser,jscomp/frontend,jscomp/ext,jscomp/depends,jscomp/core,jscomp/common,jscomp/cmij,jscomp/bsb_helper,jscomp/bsb | |||
There was a problem hiding this comment.
Is the -suppress res_syntax/testrunner still needed here?
There was a problem hiding this comment.
We don't want to be obliged to put annotations for e.g. raising possible exceptions, in the test runner.
Compile is_tag to `!== "object"` instead of `=== "string"`.
Also the comment is not emitted anymore, since there's always a tag. Not special casing means that the representation is uniform, and does not change when the type is extended. This is important with zero cost ffi, where the runtime representation is exposed to the user, to reduce possible surprises.
cristianoc
force-pushed
the
gentype_remove_rename
branch
from
5f1bd98
to
7812e1c
Compare
cristianoc
force-pushed
the
gentype_remove_rename
branch
from
7812e1c
to
bf9984a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.