Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenType: removed support for @genType.as in type definitions, which has become unnecessary. #6099

Merged
merged 20 commits into from
Mar 28, 2023
Merged

GenType: removed support for @genType.as in type definitions, which has become unnecessary. #6099

merged 20 commits into from
Mar 28, 2023

Commits on Mar 27, 2023

  1. Emit tags as strings.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    14331a6 View commit details
    Browse the repository at this point in the history

  2. Allow more general type for tags. 

    Compile is_tag to `!== "object"` instead of `=== "string"`.
    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    98b17b0 View commit details
    Browse the repository at this point in the history

  3. Do not special case variants with only 1 case with payload. 

    Also the comment is not emitted anymore, since there's always a tag.
Not special casing means that the representation is uniform, and does not change when the type is extended. This is important with zero cost ffi, where the runtime representation is exposed to the user, to reduce possible surprises.
    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    749ea89 View commit details
    Browse the repository at this point in the history

  4. Support @as("foo") to customize the representation of tags.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    e320fbb View commit details
    Browse the repository at this point in the history

  5. Add support for @tag(...) to customize the property used for the tag.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    e64cbed View commit details
    Browse the repository at this point in the history

  6. GenType: removed support for @genType.as which has become unnecessary.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    ceb362e View commit details
    Browse the repository at this point in the history

  7. Restore res_syntax analysis

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3d98d22 View commit details
    Browse the repository at this point in the history

  8. Remove object converter.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    6681a16 View commit details
    Browse the repository at this point in the history

  9. Remove conversion for variants.

    @cristianoc
    cristianoc committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    bf9984a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Emit the correct type for the variants runtime representation.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    388db47 View commit details
    Browse the repository at this point in the history

  2. Don't auto unbox variants with 1 payload.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    148829d View commit details
    Browse the repository at this point in the history

  3. Refactor.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    22a4ba5 View commit details
    Browse the repository at this point in the history

  4. Remove array converter

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    568a0fb View commit details
    Browse the repository at this point in the history

  5. Remove function converter.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    57e546c View commit details
    Browse the repository at this point in the history

  6. Allow recursive types. 

    Fixes rescript-association/genType#585
    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    61a6211 View commit details
    Browse the repository at this point in the history

  7. Remove option converter.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    63e39fa View commit details
    Browse the repository at this point in the history

  8. Remove some conversion code.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    48aea0d View commit details
    Browse the repository at this point in the history

  9. Remove conversion code.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    780ca1d View commit details
    Browse the repository at this point in the history

  10. Cleanup

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    5271e71 View commit details
    Browse the repository at this point in the history

  11. Dead code.

    @cristianoc
    cristianoc committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    3fa066b View commit details
    Browse the repository at this point in the history