-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add direct support for React 19 #1474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4485387
to
f1be85e
Compare
f1be85e
to
3489eb2
Compare
ffe2c22
to
c6f3116
Compare
9aeb41c
to
95835e2
Compare
This reverts commit 801ee64.
8c740f6
to
f11b066
Compare
gabrielmfern
added a commit
that referenced
this pull request
Jul 24, 2024
gabrielmfern
added a commit
that referenced
this pull request
Aug 5, 2024
gabrielmfern
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all of our
react
andreact-dom
peer dependencies so that they support both all18.0.0
and19.0.0
, specifically it changes them to^18.0 || ^19.0
. It also updates the React on thedemo
to be React 19 making sure that everything works there. I have also tested usingyalc
to make sure that it still works with React 18, and it does just fine.One trade I had to make was that Next was proving to cause issues if it was on canary while running for a project that used React 19. The easiest solution for now was to use React 18 with Next 14 for now. This has a trade-off of the
email export
test failing because of different React versions across the workspace. The best fix for this can only come out of this POC branch.