Optimizations

src/raft.cpp

@@ -429,7 +429,7 @@ void TRaft::ApplyResult(ITimeSource::Time now, std::unique_ptr<TResult> result,
             auto messageEx = result->Message.Cast<TMessageEx>();
             if (messageEx->Dst == 0) {
                 for (auto& [id, v] : Nodes) {
-                    v->Send(messageEx);
+                    v->Send(std::move(messageEx));
                 }
             } else {
                 Nodes[messageEx->Dst]->Send(std::move(messageEx));
@@ -452,7 +452,7 @@ void TRaft::ProcessWaiting() {
     auto commitIndex = VolatileState->CommitIndex;
     while (!waiting.empty() && waiting.top().Index <= commitIndex) {
         auto w = waiting.top(); waiting.pop();
-        w.ReplyTo->Send(w.Message);
+        w.ReplyTo->Send(std::move(w.Message));
     }
 }
 

src/raft.h

@@ -12,7 +12,7 @@
 
 struct INode {
     virtual ~INode() = default;
-    virtual void Send(const TMessageHolder<TMessage>& message) = 0;
+    virtual void Send(TMessageHolder<TMessage> message) = 0;
     virtual void Drain() = 0;
 };
 

src/server.cpp

@@ -66,8 +66,8 @@ TPromise<TMessageHolder<TMessage>>::TTask TReader::Read() {
     co_return mes;
 }
 
-void TNode::Send(const TMessageHolder<TMessage>& message) {
-    Messages.emplace_back(message);
+void TNode::Send(TMessageHolder<TMessage> message) {
+    Messages.emplace_back(std::move(message));
 }
 
 void TNode::Drain() {

src/server.h

@@ -171,7 +171,7 @@ class TNode: public INode {
         , TimeSource(ts)
     { }
 
-    void Send(const TMessageHolder<TMessage>& message) override;
+    void Send(TMessageHolder<TMessage> message) override;
     void Drain() override;
     NNet::TSocket& Sock() {
         return Socket;

test/test_raft.cpp

@@ -22,17 +22,17 @@ using namespace NNet;
 
 namespace {
 
-using OnSendFunc = const std::function<void(const TMessageHolder<TMessage>&)>;
+using OnSendFunc = const std::function<void(TMessageHolder<TMessage>)>;
 
 class TFakeNode: public INode {
 public:
     TFakeNode(const OnSendFunc& sendFunc = {})
         : SendFunc(sendFunc)
     { }
 
-    void Send(const TMessageHolder<TMessage>& message) override {
+    void Send(TMessageHolder<TMessage> message) override {
         if (SendFunc) {
-            SendFunc(message);
+            SendFunc(std::move(message));
         }
     }
 
@@ -395,8 +395,8 @@ void test_follower_append_entries_7f(void**) {
 
 void test_follower_append_entries_empty_to_empty_log(void**) {
     std::vector<TMessageHolder<TMessage>> messages;
-    auto onSend = [&](const TMessageHolder<TMessage>& message) {
-        messages.push_back(message);
+    auto onSend = [&](auto message) {
+        messages.emplace_back(std::move(message));
     };
     auto ts = std::make_shared<TFakeTimeSource>();
     auto raft = MakeRaft(onSend, 3, ts);
@@ -419,8 +419,8 @@ void test_follower_append_entries_empty_to_empty_log(void**) {
 
 void test_candidate_initiate_election(void**) {
     std::vector<TMessageHolder<TMessage>> messages;
-    auto onSend = [&](const TMessageHolder<TMessage>& message) {
-        messages.push_back(message);
+    auto onSend = [&](auto message) {
+        messages.emplace_back(std::move(message));
     };
     auto ts = std::make_shared<TFakeTimeSource>();
     auto raft = MakeRaft(onSend, 3, ts);
@@ -504,8 +504,8 @@ void test_candidate_vote_request_big(void**) {
 
 void test_candidate_vote_after_start(void**) {
     std::vector<TMessageHolder<TMessage>> messages;
-    auto onSend = [&](const TMessageHolder<TMessage>& message) {
-        messages.push_back(message);
+    auto onSend = [&](auto message) {
+        messages.emplace_back(std::move(message));
     };
     auto ts = std::make_shared<TFakeTimeSource>();
     auto raft = MakeRaft(onSend, 3, ts);