Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Alliterative IDs #5

Closed
gadenbuie opened this issue Jul 17, 2019 · 2 comments · Fixed by #6
Closed

Feature Request: Alliterative IDs #5

gadenbuie opened this issue Jul 17, 2019 · 2 comments · Fixed by #6

Comments

@gadenbuie
Copy link

gadenbuie commented Jul 17, 2019

This package is awesome and the IDs are always fantastic. But I think they're even better when they're alliterative. I think hessian_halibut nicely proves my point in this small example below.

library(tidyverse)
tibble(
  id = ids::adjective_animal(1e4, max_len = c(7, 8)),
  first_word = str_sub(id, 1, 1),
  second_word = str_sub(str_extract(id, "_\\w"), 2, 2)
) %>% 
  filter(first_word == second_word) %>% 
  sample_n(25) %>% 
  pull(id)
##  [1] "coal_civet"       "lethal_lorikeet"  "dwarven_dinosaur" "sincere_shrimp"   "ash_angora"      
##  [6] "huge_hoopoe"      "cutrate_cow"      "brassy_betafish"  "hessian_halibut"  "spotty_sable"    
## [11] "married_magpie"   "uneasy_urubu"     "pattern_pupa"     "augite_axisdeer"  "dermoid_drongo"  
## [16] "merry_marlin"     "plaid_piranha"    "chic_chital"      "skilled_spider"   "cold_cygnet"     
## [21] "covert_chafer"    "softish_seriema"  "classy_coypu"     "smiling_serpent"  "rattish_redpoll" 

I was half-joking when I proposed this on Twitter, but after looking at quite a few iterations of alliterative IDs I think they may actually be easier to work with -- or at least they're easier for me to remember over short time spans.

Edit: Just to be overly specific, the FR is for an alliterative argument in adjective_animal() with a default value of FALSE.

richfitz added a commit that referenced this issue Jul 17, 2019
@richfitz
Copy link
Member

Travis is not happy at the moment, but this is implemented now on the i5_alliterate branch

@gadenbuie
Copy link
Author

woot! Thanks @richfitz for making it happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants