This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Suggested rules #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set pubspec to use 1.8.0 - Set yaml file to use the only 1.8.0
- added extra rules not default to pedantic 1.8.0 - set a handful of rules to be ignored - changed default severity levels
|
Looking to have a discussion with the team before any of this is merged. |
- Reverted pedantic version back to 1.7.0 as min to prevent compile error - set all rules severity level to “error” to enforce standards
rezi-darren-larson
force-pushed
the
suggested_rules
branch
from
73f9ec4
to
bf214f0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial take on default rules that we should use. Up for discussion on what the team would like to use.
updated files to only use the 1.8.0 library; this will prevent issues when the library gets update. This is recommended when continuous builds or presubmit checks are in place.
Changed severity levels on a handful of rules to treat as errors and others as warnings to highlight issues (over the default info). This will help with standardizing the code. In theory, rules we decide to implement should all be set to errors if not follow, but this is an item we need to discuss as a team.