STARK: Implement the settings menu #1417

DouglasLiuDev · 2018-05-21T14:45:36Z

This pull request is corresponding to implementing the settings menu of TLJ.

DouglasLiuDev · 2018-05-21T14:46:18Z

The previous stack used to track the screen name is faulty. It is fixed here.

DouglasLiuDev · 2018-05-22T08:23:49Z

engines/stark/ui/menu/locationscreen.h

+	virtual void onClick();
+
+	/** Called when the mouse hovers the widget */
+	virtual void onMouseMove(const Common::Point &mousePos);



Just move the virtual member functions up for better readability.

DouglasLiuDev · 2018-05-23T03:52:00Z

engines/stark/ui/menu/settingsmenu.h

+public:
+	SoundManager();
+	~SoundManager() {}
+


The original game plays the testing sound in a special looping way. When the mouse is pressing down, the music plays in a loop and when pressing up, the music will play its last round. This sound manager helps to achieve this.

DouglasLiuDev · 2018-05-24T08:47:17Z

engines/stark/visual/effects/bubbles.cpp

@@ -54,6 +55,8 @@ VisualEffectBubbles::~VisualEffectBubbles() {
 }

 void VisualEffectBubbles::render(const Common::Point &position) {
+	if (!StarkSettings->getBoolSetting(Settings::kSpecialFX)) return;
+


Need to know a location with visual effects to test the correctness. Any suggestion?

changeLocation 40 00 => green fireflies
changeLocation 55 00 => bubbles and fishes

DouglasLiuDev · 2018-05-24T08:49:16Z

engines/stark/ui/world/fmvscreen.cpp

+	if (!StarkSettings->getBoolSetting(Settings::kHighFMV) && StarkSettings->hasLowResFMV()) {
+		name.erase(name.size() - 4);
+		name += "_lo_res.bbb";
+	}


Is it possible that some versions of TLJ will use this suffix in upper-cases?

It does not matter, the SearchManager used to lookup files in ResidualVM is completely case insensitive.

DouglasLiuDev · 2018-05-24T08:51:10Z

For the setting of fmv quality, right now it is assumed that all versions of TLJ will at least contain the high-quality fmv. By default high-quality one is used since we are all on modern computers.

DouglasLiuDev · 2018-05-25T03:23:38Z

One problem related to the fmv quality setting: I test it with the demo version, and the low-resolution fmv has the wrong ratio when playing.

bgK · 2018-05-26T05:34:34Z

engines/stark/ui/menu/settingsmenu.cpp

+
+void SettingsMenuScreen::close() {
+	StaticLocationScreen::close();
+	_soundManager.stop();


There is a small memory management problem here:

==5646==ERROR: AddressSanitizer: heap-use-after-free on address 0x61200009c144 at pc 0x5651db86c64a bp 0x7fffeb2e10b0 sp 0x7fffeb2e10a0 READ of size 4 at 0x61200009c144 thread T0 #0 0x5651db86c649 in Stark::Resources::Sound::stop() ../engines/stark/resources/sound.cpp:137 #1 0x5651db8bfb41 in Stark::SoundManager::stop() ../engines/stark/ui/menu/settingsmenu.cpp:379 #2 0x5651db8bdd03 in Stark::SettingsMenuScreen::close() ../engines/stark/ui/menu/settingsmenu.cpp:199 #3 0x5651db8a5866 in Stark::UserInterface::changeScreen(Stark::Screen::Name) ../engines/stark/services/userinterface.cpp:156 #4 0x5651db8a5999 in Stark::UserInterface::backPrevScreen() ../engines/stark/services/userinterface.cpp:164 #5 0x5651db8bdf5f in Stark::SettingsMenuScreen::backHandler() ../engines/stark/ui/menu/settingsmenu.cpp:236 #6 0x5651db8c15e4 in Common::Functor0Mem<void, Stark::SettingsMenuScreen>::operator()() const ../common/func.h:388 #7 0x5651db8b6e73 in Stark::StaticLocationWidget::onClick() ../engines/stark/ui/menu/locationscreen.cpp:191 #8 0x5651db8b61a3 in Stark::StaticLocationScreen::onClick(Common::Point const&) ../engines/stark/ui/menu/locationscreen.cpp:113 #9 0x5651db8c2313 in Stark::Window::handleClick() ../engines/stark/ui/window.cpp:94 #10 0x5651db8b3fd3 in Stark::SingleWindowScreen::handleClick() ../engines/stark/ui/screen.h:81 #11 0x5651db8a523d in Stark::UserInterface::handleClick() ../engines/stark/services/userinterface.cpp:108 #12 0x5651db82222a in Stark::StarkEngine::processEvents() ../engines/stark/stark.cpp:220 #13 0x5651db82198a in Stark::StarkEngine::mainLoop() ../engines/stark/stark.cpp:170 #14 0x5651db8217a6 in Stark::StarkEngine::run() ../engines/stark/stark.cpp:158 #15 0x5651db4332a1 in runGame ../base/main.cpp:265 #16 0x5651db435b8c in scummvm_main ../base/main.cpp:532 #17 0x5651db42ee36 in main ../backends/platform/sdl/posix/posix-main.cpp:45 #18 0x7f24c2fb906a in __libc_start_main (/usr/lib/libc.so.6+0x2306a) #19 0x5651db4285b9 in _start (/home/bbouclet/prog/residualvm/build/residualvm+0x1a85b9) 0x61200009c144 is located 260 bytes inside of 264-byte region [0x61200009c040,0x61200009c148) freed by thread T0 here: #0 0x7f24c61529c9 in operator delete(void*) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cc:135 #1 0x5651db86b3f3 in Stark::Resources::Sound::~Sound() ../engines/stark/resources/sound.cpp:40 #2 0x5651db8613d5 in Stark::Resources::Object::~Object() ../engines/stark/resources/object.cpp:111 #3 0x5651db8fdd8a in Stark::Resources::Container::~Container() ../engines/stark/resources/container.cpp:30 #4 0x5651db8fdda5 in Stark::Resources::Container::~Container() ../engines/stark/resources/container.cpp:31 #5 0x5651db8613d5 in Stark::Resources::Object::~Object() ../engines/stark/resources/object.cpp:111 #6 0x5651db938be6 in Stark::Resources::Location::~Location() ../engines/stark/resources/location.cpp:48 #7 0x5651db938c01 in Stark::Resources::Location::~Location() ../engines/stark/resources/location.cpp:49 #8 0x5651db87a404 in Stark::ArchiveLoader::LoadedArchive::~LoadedArchive() ../engines/stark/services/archiveloader.cpp:44 #9 0x5651db87aa27 in Stark::ArchiveLoader::unloadUnused() ../engines/stark/services/archiveloader.cpp:75 #10 0x5651db89d82d in Stark::StaticProvider::unloadLocation(Stark::Resources::Location*) ../engines/stark/services/staticprovider.cpp:151 #11 0x5651db8b5be1 in Stark::StaticLocationScreen::close() ../engines/stark/ui/menu/locationscreen.cpp:63 #12 0x5651db8bdcf3 in Stark::SettingsMenuScreen::close() ../engines/stark/ui/menu/settingsmenu.cpp:198 #13 0x5651db8a5866 in Stark::UserInterface::changeScreen(Stark::Screen::Name) ../engines/stark/services/userinterface.cpp:156 #14 0x5651db8a5999 in Stark::UserInterface::backPrevScreen() ../engines/stark/services/userinterface.cpp:164 #15 0x5651db8bdf5f in Stark::SettingsMenuScreen::backHandler() ../engines/stark/ui/menu/settingsmenu.cpp:236 #16 0x5651db8c15e4 in Common::Functor0Mem<void, Stark::SettingsMenuScreen>::operator()() const ../common/func.h:388 #17 0x5651db8b6e73 in Stark::StaticLocationWidget::onClick() ../engines/stark/ui/menu/locationscreen.cpp:191 #18 0x5651db8b61a3 in Stark::StaticLocationScreen::onClick(Common::Point const&) ../engines/stark/ui/menu/locationscreen.cpp:113 #19 0x5651db8c2313 in Stark::Window::handleClick() ../engines/stark/ui/window.cpp:94 #20 0x5651db8b3fd3 in Stark::SingleWindowScreen::handleClick() ../engines/stark/ui/screen.h:81 #21 0x5651db8a523d in Stark::UserInterface::handleClick() ../engines/stark/services/userinterface.cpp:108 #22 0x5651db82222a in Stark::StarkEngine::processEvents() ../engines/stark/stark.cpp:220 #23 0x5651db82198a in Stark::StarkEngine::mainLoop() ../engines/stark/stark.cpp:170 #24 0x5651db8217a6 in Stark::StarkEngine::run() ../engines/stark/stark.cpp:158 #25 0x5651db4332a1 in runGame ../base/main.cpp:265 #26 0x5651db435b8c in scummvm_main ../base/main.cpp:532 #27 0x5651db42ee36 in main ../backends/platform/sdl/posix/posix-main.cpp:45 #28 0x7f24c2fb906a in __libc_start_main (/usr/lib/libc.so.6+0x2306a) previously allocated by thread T0 here: #0 0x7f24c6151a91 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cc:90 #1 0x5651db8db88f in Stark::Formats::XRCReader::createResource(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:226 #2 0x5651db8db150 in Stark::Formats::XRCReader::importResource(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:158 #3 0x5651db8dca72 in Stark::Formats::XRCReader::importResourceChildren(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:326 #4 0x5651db8db17a in Stark::Formats::XRCReader::importResource(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:160 #5 0x5651db8dca72 in Stark::Formats::XRCReader::importResourceChildren(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:326 #6 0x5651db8db17a in Stark::Formats::XRCReader::importResource(Stark::Formats::XRCReadStream*, Stark::Resources::Object*) ../engines/stark/formats/xrc.cpp:160 #7 0x5651db8dafce in Stark::Formats::XRCReader::importTree(Stark::Formats::XARCArchive*) ../engines/stark/formats/xrc.cpp:150 #8 0x5651db87a443 in Stark::ArchiveLoader::LoadedArchive::importResources() ../engines/stark/services/archiveloader.cpp:49 #9 0x5651db87a803 in Stark::ArchiveLoader::load(Common::String const&) ../engines/stark/services/archiveloader.cpp:67 #10 0x5651db89d1ea in Stark::StaticProvider::loadLocation(char const*) ../engines/stark/services/staticprovider.cpp:129 #11 0x5651db8b5b33 in Stark::StaticLocationScreen::open() ../engines/stark/ui/menu/locationscreen.cpp:57 #12 0x5651db8bb688 in Stark::SettingsMenuScreen::open() ../engines/stark/ui/menu/settingsmenu.cpp:44 #13 0x5651db8a591a in Stark::UserInterface::changeScreen(Stark::Screen::Name) ../engines/stark/services/userinterface.cpp:158 #14 0x5651db8ba456 in Stark::MainMenuScreen::settingsHandler() ../engines/stark/ui/menu/mainmenu.cpp:174 #15 0x5651db8bb0c8 in Common::Functor0Mem<void, Stark::MainMenuScreen>::operator()() const ../common/func.h:388 #16 0x5651db8b6e73 in Stark::StaticLocationWidget::onClick() ../engines/stark/ui/menu/locationscreen.cpp:191 #17 0x5651db8b61a3 in Stark::StaticLocationScreen::onClick(Common::Point const&) ../engines/stark/ui/menu/locationscreen.cpp:113 #18 0x5651db8c2313 in Stark::Window::handleClick() ../engines/stark/ui/window.cpp:94 #19 0x5651db8b3fd3 in Stark::SingleWindowScreen::handleClick() ../engines/stark/ui/screen.h:81 #20 0x5651db8a523d in Stark::UserInterface::handleClick() ../engines/stark/services/userinterface.cpp:108 #21 0x5651db82222a in Stark::StarkEngine::processEvents() ../engines/stark/stark.cpp:220 #22 0x5651db82198a in Stark::StarkEngine::mainLoop() ../engines/stark/stark.cpp:170 #23 0x5651db8217a6 in Stark::StarkEngine::run() ../engines/stark/stark.cpp:158 #24 0x5651db4332a1 in runGame ../base/main.cpp:265 #25 0x5651db435b8c in scummvm_main ../base/main.cpp:532 #26 0x5651db42ee36 in main ../backends/platform/sdl/posix/posix-main.cpp:45 #27 0x7f24c2fb906a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)

bgK · 2018-05-26T06:28:12Z

One problem related to the fmv quality setting: I test it with the demo version, and the low-resolution fmv has the wrong ratio when playing.

Can you look into fixing it?

DouglasLiuDev · 2018-05-26T14:21:23Z

I modified all three findBonesMesh(), yet based on the testing on the game and demo, at least at the beginning only the GlobalItemTemplete::findBonesMesh() one is used. Not sure whether it is needed to change all three of them.

BTW, the quality change is almost unnoticeable...

DouglasLiuDev · 2018-05-27T03:44:46Z

About the low-res FMV problem: it seems that the way low-res FMV works is that it is obtained through shrinking the original FMV on the height, so the ratio is naturally wrong. Right now I don't see a way to stretch it back. Looks like each frame of an FMV is decoded as a surface, and it does not provide stretching functionality.

DouglasLiuDev · 2018-05-27T05:19:30Z

engines/stark/ui/menu/settingsmenu.cpp

-	_maxX = _bgPosition.x + _bgWidth - _sliderWidth / 2;
+	_bgPosition.x = 313;
+	_bgPosition.y = 303 + _settingIndex * 51;
+	_sliderPosition.y = _bgPosition.y;



Not completely identical to the original game, but should simulate well enough.

bgK · 2018-05-27T11:52:27Z

engines/stark/services/settings.cpp

+	ConfMan.registerDefault(_boolKey[kTimeSkip], false);
+
+	// Use the FunCom logo video to check low-resolution fmv
+	_hasLowRes = StarkArchiveLoader->getExternalFile("1402_lo_res.bbb", "Global/");


This causes a memory leak when the file is found:

Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7ff445ad1a91 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cc:90 #1 0x562c7ce33a29 in StdioStream::makeFromPath(Common::String const&, bool) ../backends/fs/stdiostream.cpp:102 #2 0x562c7ce263f4 in POSIXFilesystemNode::createReadStream() ../backends/fs/posix/posix-fs.cpp:254 #3 0x562c7d0598e7 in Common::FSNode::createReadStream() const ../common/fs.cpp:140 #4 0x562c7d05a6ce in Common::FSDirectory::createReadStreamForMember(Common::String const&) const ../common/fs.cpp:233 #5 0x562c7d03f504 in Common::SearchSet::createReadStreamForMember(Common::String const&) const ../common/archive.cpp:260 #6 0x562c7cbe460d in Stark::ArchiveLoader::getExternalFile(Common::String const&, Common::String const&) const ../engines/stark/services/archiveloader.cpp:153 #7 0x562c7cc11c0a in Stark::Settings::Settings(Audio::Mixer*) ../engines/stark/services/settings.cpp:56 #8 0x562c7cb7c35c in Stark::StarkEngine::run() ../engines/stark/stark.cpp:126 #9 0x562c7cb41c61 in runGame ../base/main.cpp:265 #10 0x562c7cb4454c in scummvm_main ../base/main.cpp:532 #11 0x562c7cb3d7f6 in main ../backends/platform/sdl/posix/posix-main.cpp:45 #12 0x7ff44271b06a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)

bgK · 2018-05-27T12:00:11Z

engines/stark/ui/menu/settingsmenu.cpp

+			nullptr));
+	_widgets.back()->setVisible(false);
+
+	if (!isDemo()) {


This test should be different. My 4 CD French version does not have AllowFF either. Perhaps test if the render entry exists?

bgK · 2018-05-27T12:06:38Z

engines/stark/ui/menu/settingsmenu.h

+/**
+ * Manager of test sound
+ */
+class SoundManager {


Perhaps this class should be renamed to TestSoundManager to better reflect its responsibility.

bgK · 2018-05-27T12:10:22Z

engines/stark/ui/menu/settingsmenu.h

+	SoundManager _soundManager;
+
+	bool isDemo() {
+		return StarkGameDescription->flags & ADGF_DEMO;


There are now two implementations of isDemo. I think it'd be better to put one in StarkSettings and reuse it.

bgK · 2018-05-27T12:11:38Z

engines/stark/services/settings.h

+	bool hasLowResFMV() { return _hasLowRes; }
+
+private:
+	const static int _maxVolume = 256;


This is not used.

bgK · 2018-05-27T12:15:40Z

engines/stark/services/settings.cpp

+	_hasLowRes = StarkArchiveLoader->getExternalFile("1402_lo_res.bbb", "Global/");
+
+	// Apply the volume
+	setIntSetting(kVoice, getIntSetting(kVoice));


Is this really needed?

residualvm/engines/engine.cpp

Line 561 in 3ec0165

void Engine::syncSoundSettings() {

Should already do the same.

bgK · 2018-05-27T12:34:04Z

engines/stark/stark.cpp

@@ -70,11 +71,9 @@ StarkEngine::StarkEngine(OSystem *syst, const ADGameDescription *gameDesc) :
 		_diary(nullptr),
 		_userInterface(nullptr),
 		_fontProvider(nullptr),
+		_settings(nullptr),
 		_lastClickTime(0) {
 	_mixer->setVolumeForSoundType(Audio::Mixer::kPlainSoundType, 127);


We don't need this line either as we don't use kPlainSoundType and syncSoundSettings sets it anyways.

residualvm/engines/engine.cpp

Line 585 in 3ec0165

_mixer->setVolumeForSoundType(Audio::Mixer::kPlainSoundType, Audio::Mixer::kMaxMixerVolume);

bgK · 2018-05-27T12:44:28Z

engines/stark/services/settings.cpp

+Settings::Settings(Audio::Mixer *mixer) :
+		_mixer(mixer) {
+	// Initialize keys
+	_boolKey[kHighModel] = "high_model";


The settings name are user facing through the configuration file. I suggest using more explicit names:

high_model => use_high_resolution_models

specialfx => enable_special_effects

shadow => enable_shadows

high_fmv => play_high_resolution_videos

DouglasLiuDev · 2018-05-27T14:23:32Z

Based on my current thinking of the save & load menu, it will provide more flexibility if StaticLocationWidget can have empty RenderEntry field, since some complex widgets may need an empty base class as their container. This naturally fixed any problem due to different versions of TLJ that have different widgets. A debug message will still be printed for now.

bgK · 2018-05-28T08:23:40Z

Thanks for your changes. This is looking very good now. Can we merge?

Based on my current thinking of the save & load menu, it will provide more flexibility if StaticLocationWidget can have empty RenderEntry field, since some complex widgets may need an empty base class as their container.

Sounds ok. Maybe adding a parent class that does not have a RenderEntry to StaticLocationWidget could also work.

DouglasLiuDev · 2018-05-29T05:10:07Z

@bgK I don't have more improvement in mind now. If you think it is good enough, we can merge them now :D

bgK · 2018-05-29T05:40:38Z

engines/stark/ui/world/fmvscreen.cpp

@@ -77,7 +83,7 @@ void FMVScreen::onRender() {
 		stop();
 	}

-	_surfaceRenderer->render(_texture, Common::Point(0, Gfx::Driver::kTopBorderHeight));
+	_surfaceRenderer->render(_texture, Common::Point(0, Gfx::Driver::kTopBorderHeight), 640, 365);


Please use the constants defined here:

residualvm/engines/stark/gfx/driver.h

Line 144 in 13e0799

static const int32 kGameViewportHeight = 365;

bgK · 2018-05-29T05:47:00Z

engines/stark/gfx/openglssurface.h

@@ -46,7 +46,8 @@ class OpenGLSSurfaceRenderer : public SurfaceRenderer {
 	virtual ~OpenGLSSurfaceRenderer();

 	// SurfaceRenderer API
-	void render(const Texture *texture, const Common::Point &dest);
+	void render(const Texture *texture, const Common::Point &dest) override;
+	void render(const Texture *texture, const Common::Point &dest, const float width, const float height) override;


I can't see a reason why the destination rectangle dimensions would need to be floating point numbers. I'd prefer keeping the width and height as integers so it's more clear dimensions in pixels are expected, and not some kind of normalized coordinates.

The original implementation in render() used floating point in the width and height. I thought it is a must.

bgK · 2018-05-29T06:10:07Z

All good!

DouglasLiuDev added 2 commits May 21, 2018 22:28

STARK: Fix the screen name stack

74f3565

STARK: Build the Settings and link it with other screens

19fed32

DouglasLiuDev added 2 commits May 22, 2018 11:27

STARK: Change numbers to enums for readability

ab76813

STARK: Implement CheckBoxWidget

83f3126

DouglasLiuDev force-pushed the branch-settings branch from f188507 to 83f3126 Compare May 22, 2018 08:22

DouglasLiuDev commented May 22, 2018

View reviewed changes

DouglasLiuDev added 3 commits May 22, 2018 18:20

STARK: Roughly Implement VolumeWidget

121cbc0

STARK: Implement the dragged widget

4159a8b

STARK: Add the sound on the slider

2b40b95

DouglasLiuDev commented May 23, 2018

View reviewed changes

DouglasLiuDev added 5 commits May 24, 2018 14:50

STARK: Implement settings save and load

a8c3b32

STARK: Enable subtitles setting

ef83a24

STARK: Enable special effects setting (unchecked)

eacc77a

STARK: Enable time skip setting

eeb0bc7

STARK: Enable video quality setting

86732d7

DouglasLiuDev commented May 24, 2018

View reviewed changes

DouglasLiuDev added 3 commits May 25, 2018 11:09

STARK: Enable volume setting

a5df211

STARK: SpecialFX setting checked

e94d2a7

STARK: Add SpecialFX comments

1079124

bgK reviewed May 26, 2018

View reviewed changes

DouglasLiuDev added 2 commits May 26, 2018 15:01

STARK: Fix SoundManager's memory problem

464b9bb

STARK: Enable low-quality model setting

7001c9c

STARK: Twist the sliders' position

dbb16f1

DouglasLiuDev commented May 27, 2018

View reviewed changes

bgK reviewed May 27, 2018

View reviewed changes

DouglasLiuDev added 4 commits May 27, 2018 21:53

STARK: Small fixing on settings

484b36b

STARK: Move isDemo() to Settings service

a176e21

STARK: Name changed

924359e

STARK: Allow StaticLocationWidget has empty renderentry

03eeb91

STARK: Fix low-res FMV wrong ration problem

841c798

bgK reviewed May 29, 2018

View reviewed changes

STARK: Small fixing

ccf04a2

bgK merged commit 36e14c8 into residualvm:master May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STARK: Implement the settings menu #1417

STARK: Implement the settings menu #1417

DouglasLiuDev commented May 21, 2018

DouglasLiuDev commented May 21, 2018

DouglasLiuDev May 22, 2018

DouglasLiuDev May 23, 2018

DouglasLiuDev May 24, 2018

bgK May 24, 2018

DouglasLiuDev May 24, 2018

bgK May 24, 2018

DouglasLiuDev commented May 24, 2018

DouglasLiuDev commented May 25, 2018

bgK May 26, 2018

bgK commented May 26, 2018

DouglasLiuDev commented May 26, 2018

DouglasLiuDev commented May 27, 2018

DouglasLiuDev May 27, 2018

bgK May 27, 2018

bgK May 27, 2018

bgK May 27, 2018

bgK May 27, 2018 •

edited

bgK May 27, 2018

bgK May 27, 2018

bgK May 27, 2018

bgK May 27, 2018

DouglasLiuDev commented May 27, 2018

bgK commented May 28, 2018

DouglasLiuDev commented May 29, 2018

bgK May 29, 2018

bgK May 29, 2018

DouglasLiuDev May 29, 2018

bgK commented May 29, 2018

STARK: Implement the settings menu #1417

STARK: Implement the settings menu #1417

Conversation

DouglasLiuDev commented May 21, 2018

DouglasLiuDev commented May 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DouglasLiuDev commented May 24, 2018

DouglasLiuDev commented May 25, 2018

Choose a reason for hiding this comment

bgK commented May 26, 2018

DouglasLiuDev commented May 26, 2018

DouglasLiuDev commented May 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgK May 27, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DouglasLiuDev commented May 27, 2018

bgK commented May 28, 2018

DouglasLiuDev commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgK commented May 29, 2018

bgK May 27, 2018 •

edited