Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

STARK: Implement the settings menu #1417

Merged
merged 24 commits into from
May 29, 2018
Merged

STARK: Implement the settings menu #1417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
74f3565
STARK: Fix the screen name stack
Dougaak May 21, 2018
19fed32
STARK: Build the Settings and link it with other screens
Dougaak May 21, 2018
ab76813
STARK: Change numbers to enums for readability
Dougaak May 22, 2018
83f3126
STARK: Implement CheckBoxWidget
Dougaak May 22, 2018
121cbc0
STARK: Roughly Implement VolumeWidget
Dougaak May 22, 2018
4159a8b
STARK: Implement the dragged widget
Dougaak May 23, 2018
2b40b95
STARK: Add the sound on the slider
Dougaak May 23, 2018
a8c3b32
STARK: Implement settings save and load
Dougaak May 24, 2018
ef83a24
STARK: Enable subtitles setting
Dougaak May 24, 2018
eacc77a
STARK: Enable special effects setting (unchecked)
Dougaak May 24, 2018
eeb0bc7
STARK: Enable time skip setting
Dougaak May 24, 2018
86732d7
STARK: Enable video quality setting
Dougaak May 24, 2018
a5df211
STARK: Enable volume setting
Dougaak May 25, 2018
e94d2a7
STARK: SpecialFX setting checked
Dougaak May 25, 2018
1079124
STARK: Add SpecialFX comments
Dougaak May 25, 2018
464b9bb
STARK: Fix SoundManager's memory problem
Dougaak May 26, 2018
7001c9c
STARK: Enable low-quality model setting
Dougaak May 26, 2018
dbb16f1
STARK: Twist the sliders' position
Dougaak May 27, 2018
484b36b
STARK: Small fixing on settings
Dougaak May 27, 2018
a176e21
STARK: Move isDemo() to Settings service
Dougaak May 27, 2018
924359e
STARK: Name changed
Dougaak May 27, 2018
03eeb91
STARK: Allow StaticLocationWidget has empty renderentry
Dougaak May 27, 2018
841c798
STARK: Fix low-res FMV wrong ration problem
Dougaak May 29, 2018
ccf04a2
STARK: Small fixing
Dougaak May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions engines/stark/visual/effects/bubbles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

#include "engines/stark/services/global.h"
#include "engines/stark/services/services.h"
#include "engines/stark/services/settings.h"

namespace Stark {

Expand All @@ -54,6 +55,8 @@ VisualEffectBubbles::~VisualEffectBubbles() {
}

void VisualEffectBubbles::render(const Common::Point &position) {
if (!StarkSettings->getBoolSetting(Settings::kSpecialFX)) return;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to know a location with visual effects to test the correctness. Any suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeLocation 40 00 => green fireflies
changeLocation 55 00 => bubbles and fishes

_timeRemainingUntilNextUpdate -= StarkGlobal->getMillisecondsPerGameloop();
if (_timeRemainingUntilNextUpdate <= 0) {
update();
Expand Down
3 changes: 3 additions & 0 deletions engines/stark/visual/effects/fireflies.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

#include "engines/stark/services/global.h"
#include "engines/stark/services/services.h"
#include "engines/stark/services/settings.h"

namespace Stark {

Expand All @@ -48,6 +49,8 @@ VisualEffectFireFlies::~VisualEffectFireFlies() {
}

void VisualEffectFireFlies::render(const Common::Point &position) {
if (!StarkSettings->getBoolSetting(Settings::kSpecialFX)) return;

_timeRemainingUntilNextUpdate -= StarkGlobal->getMillisecondsPerGameloop();
if (_timeRemainingUntilNextUpdate <= 0) {
update();
Expand Down
3 changes: 3 additions & 0 deletions engines/stark/visual/effects/fish.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

#include "engines/stark/services/global.h"
#include "engines/stark/services/services.h"
#include "engines/stark/services/settings.h"

namespace Stark {

Expand All @@ -59,6 +60,8 @@ VisualEffectFish::~VisualEffectFish() {
}

void VisualEffectFish::render(const Common::Point &position) {
if (!StarkSettings->getBoolSetting(Settings::kSpecialFX)) return;

_timeRemainingUntilNextUpdate -= StarkGlobal->getMillisecondsPerGameloop();
if (_timeRemainingUntilNextUpdate <= 0) {
update();
Expand Down