-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GST inward supply should be updated every time the linked document is canceled #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
changed the title
fix: GST inward supply should be updated every time the linked document is canceled, regardless of the status of the linked document.
fix: GST inward supply should be updated every time the linked document is canceled, regardless of the reconciliation status of the linked document.
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2147 +/- ##
===========================================
+ Coverage 65.47% 65.50% +0.02%
===========================================
Files 105 105
Lines 8843 8839 -4
===========================================
Hits 5790 5790
+ Misses 3053 3049 -4 ☔ View full report in Codecov by Sentry. |
1 task
1 task
Sanket322
changed the title
fix: GST inward supply should be updated every time the linked document is canceled, regardless of the reconciliation status of the linked document.
fix: GST inward supply should be updated every time the linked document is canceled
May 22, 2024
vorasmit
reviewed
May 22, 2024
india_compliance/patches/v14/unset_matching_link_for_cancelled_doc.py
Outdated
Show resolved
Hide resolved
vorasmit
previously approved these changes
May 23, 2024
vorasmit
added a commit
that referenced
this pull request
May 23, 2024
…tfix/pr-2147 fix: GST inward supply should be updated every time the linked document is canceled (backport #2147)
vorasmit
added a commit
that referenced
this pull request
May 23, 2024
…tfix/pr-2147 fix: GST inward supply should be updated every time the linked document is canceled (backport #2147)
india-compliance-bot
added a commit
that referenced
this pull request
May 27, 2024
## [14.26.6](v14.26.5...v14.26.6) (2024-05-27) ### Bug Fixes * add `match_found` in reconciliation status and patch ([#2057](#2057)) ([5d419fb](5d419fb)), closes [#2054](#2054) * add description and remove progress ([f0e0577](f0e0577)) * change download history while change in company_gstin from ([208d690](208d690)) * change import history as per return type ([d036bca](d036bca)) * check if data found and update progress ([b684da3](b684da3)) * complete minor todo's and fixes, update links to documentation ([#2121](#2121)) ([96dd39d](96dd39d)), closes [/github.com/resilient-tech/india-compliance/blob/develop/india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py#L1367](https://github.com//github.com/resilient-tech/india-compliance/blob/develop/india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py/issues/L1367) * condition for b2cl in gstr-1 data ([bae56ef](bae56ef)) * exclude place of supply for impg in purchase reco ([8188a45](8188a45)) * exclude same gstin transactions from gstr3b ([#2158](#2158)) ([7633ebf](7633ebf)) * floating point error for tax rounding ([2a55067](2a55067)) * GST inward supply should be updated every time the linked document is canceled ([#2147](#2147)) ([35dd205](35dd205)) * handle empty GSTIN value in `get_pan_level_data` method ([#2172](#2172)) ([9be09ce](9be09ce)), closes [#2115](#2115) * handle empty place of supply in GST Sales Register Beta Report ([2e2610a](2e2610a)) * include items without HSN Code in outward hsn summary ([62ac2a1](62ac2a1)) * include Nil-Rated Exports in GSTR-1 ([#2150](#2150)) ([e466bfc](e466bfc)) * include Nil-Rated Exports in GSTR-1 (backport [#2150](#2150)) ([#2164](#2164)) ([8eb88bb](8eb88bb)) * non-group tds payable account for tax withholding category ([dd5f97e](dd5f97e)) * Purchase Reconciliation data not generated error handling ([#2145](#2145)) ([77cf3f7](77cf3f7)) * remove extra calculation ([659dfd5](659dfd5)) * support custom print format for e-Waybill ([cb7fabf](cb7fabf)) * test case ([c08e091](c08e091)) * update tax rounding difference in the last item ([b987401](b987401)) * use base_tax_amount_after_discount_amount instead of tax_amount ([#2144](#2144)) ([9d6e7b5](9d6e7b5)), closes [#2143](#2143)
india-compliance-bot
added a commit
that referenced
this pull request
May 27, 2024
## [15.7.5](v15.7.4...v15.7.5) (2024-05-27) ### Bug Fixes * add `match_found` in reconciliation status and patch ([#2057](#2057)) ([127ae4e](127ae4e)), closes [#2054](#2054) * add description and remove progress ([43e92a8](43e92a8)) * change download history while change in company_gstin from ([5a7f374](5a7f374)) * change import history as per return type ([fb200a8](fb200a8)) * check if data found and update progress ([a0ae06a](a0ae06a)) * complete minor todo's and fixes, update links to documentation ([#2121](#2121)) ([ea8cfd0](ea8cfd0)), closes [/github.com/resilient-tech/india-compliance/blob/develop/india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py#L1367](https://github.com//github.com/resilient-tech/india-compliance/blob/develop/india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py/issues/L1367) * condition for b2cl in gstr-1 data ([782eb54](782eb54)) * exclude place of supply for impg in purchase reco ([47a6c5e](47a6c5e)) * exclude same gstin transactions from gstr3b ([#2158](#2158)) ([0cd8d2b](0cd8d2b)) * floating point error for tax rounding ([87ac0fd](87ac0fd)) * GST inward supply should be updated every time the linked document is canceled ([#2147](#2147)) ([3cba75b](3cba75b)) * handle empty GSTIN value in `get_pan_level_data` method ([#2172](#2172)) ([d1537fb](d1537fb)), closes [#2115](#2115) * handle empty place of supply in GST Sales Register Beta Report ([c20e3ac](c20e3ac)) * **ic page:** theme of ic page similar to v15 ([710911c](710911c)) * include items without HSN Code in outward hsn summary ([50796e4](50796e4)) * include Nil-Rated Exports in GSTR-1 ([#2150](#2150)) ([0d98174](0d98174)) * non-group tds payable account for tax withholding category ([0293d74](0293d74)) * Purchase Reconciliation data not generated error handling ([#2145](#2145)) ([3c18835](3c18835)) * remove extra calculation ([05f8c79](05f8c79)) * rename variable to follow Erpnext naming ([e7fe94a](e7fe94a)) * resolved discrepancy in function arguments for depreciation calcu… ([#2159](#2159)) ([81a5690](81a5690)) * support custom print format for e-Waybill ([4cd634a](4cd634a)) * test case ([2c6efed](2c6efed)) * update tax rounding difference in the last item ([5a4f44a](5a4f44a)) * use base_tax_amount_after_discount_amount instead of tax_amount ([#2144](#2144)) ([0873cfd](0873cfd)), closes [#2143](#2143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #2141