-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creation of NuGet package #32
Conversation
I'd be glad to help out. However, I would be the owner of the package in the NuGet gallery. Are you fine with that? |
@thoemmi I added you as a collaborator of this repo, but please do continue making pull requests for your changes. And feel free to help out with whatever time you have! Glad more people are using this library. |
I just checked the nuspec specification: both multiple authors and owners are possible. I'll create another PR for the updated nuspec file tomorrow. Thanks for making me a collaborator. I hope I can contribute one or another helpful change. Of course I won't commit to the repository directly but via PRs. |
Since we're using appveyor for automated CI, I would expect the CI build to automatically push the nuget package to nuget. Depending on how the appveyor CI project (https://ci.appveyor.com/project/dblock/resourcelib) is configured, it may require updates to appveyor.yml. But I don't expect the nuget API key to be exposed in appveyor.yml because that's checked into the repository. So since the owner of the appveyor CI project is @dblock, I would think he would have to update the appveyor CI project as follows:
|
When you add publishing NuGet packages in AppVeyor, you can encrypt the NuGet API key in
AppVeyor even hosts a page where you can encrypt your key. It can then be committed to the public repository securely. Unfortunately, there's not much doumentation about it. I guess the encryption must be done by the account owning the CI build. |
But before starting to publish CI builds to NuGet gallery, maybe we should consider using semantic versioning to distinguish beta builds from official releases. As far as I see resourcelib uses the MSBuild Version Task to generate dynamic version info. However, I'd suggest to switch to GitVersion. Comments? |
I agree wrt semantic versioning. LMK what I need/can do wrt keys once you guys sorted it out. I am here to help. |
With this PR, calling
build.bat all
will also create a NuGet package in thetarget\$(configuration)
folder.If you want to automate the upload to the NuGet gallery, you can instruct AppVeyor to do so.
This also fixes #13.