Merge develop into master for v0.9.1 release
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added water quality and other activity modules that are under development.
Create `develop-WaterQuality` for work on non-hydrolic modules
Update develop-WaterQuality from Master
Update WaterQuality feature branch from develop
…to develop-WaterQuality
Update WQ from master
adding JupyterLab extension depdendencies
…to develop-WaterQuality
Develop water quality
…ting SNOW.py, SaveTable.csv -- full implementation of degree-day option
…inements for flags based on additional testing
…in optional tables
…r refinements expected
…nd of last time period
Merge Unit testing work from RESPEC
Timeseries with irregular timestep do not conform to the requirement for setting the index.freq argument. This results in a value error. This commit adds a try except to allow for the reader to handle timeseries with irregular timesteps. However as of this commit, the model with not be able to run these timeseries. Additional effort is needed to handle timesteps with irregular timesteps.
Renames internal functions with prepending underscore to indicate they are private functions as per PEP8.
- handle special h5 IQUAL constituent name matching with HBN names
rename bits_to_date to indicate it is an internal function.
Adds deprecation warning to functions replaced by the updated WDMReader.
Merge develop_readWDM into develop to read time series by block & group
- based on operation, activity, and opn id, plus constituent name and time unit - this shows most rchres-hydr outputs are matching
- Removed repeating block of install instructions. - Updated name of Conda environment and added description for `environment_dev.yml`
Merge LimnoTech readWDM & other updates to RESPEC develop
readWDM.py -- commented out a few instances of njit to be compatible with other versions of numba
|
@PaulDudaRESPEC, thanks for reviewing and merging our PR #52! I just realized that with that PR, This is OK, but I wanted you to know that after merging with I had set that version number in our |
|
Good! I plan to do a little more testing and then start drafting a new release. |
aufdenkampe
changed the title
develop into master for v0.9.0 releasedevelop into master for v0.9.1 release
PaulDudaRESPEC
pushed a commit
that referenced
this pull request
Oct 19, 2021
Pull in WQ update from Todd into testing branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Water quality and regression testing