Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive Devices list keep reordering itself #234

Closed
jjavierdguezas opened this issue Jul 1, 2020 · 6 comments · Fixed by #422
Closed

Inactive Devices list keep reordering itself #234

jjavierdguezas opened this issue Jul 1, 2020 · 6 comments · Fixed by #422
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@jjavierdguezas
Copy link
Contributor

Version: 0.5.0
Electron: 8.3.0
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18362

If this is intended, then just close this issue... but I personally think it is a bit weird

When managing the devices, no matters how I drag and drop an item in the Inactive Devices list, it keeps reordering itself. Maybe I want to keep an order on that list or I made a mistake and moved the wrong device to inactives, after a drag&drop action the moved device should be where I dropped it, but that is not always the case
This only happens in the Inactive Devices list

device list

@jjavierdguezas jjavierdguezas changed the title Device list keep reordering itself Incative Devices list keep reordering itself Jul 1, 2020
@jjavierdguezas jjavierdguezas changed the title Incative Devices list keep reordering itself Inactive Devices list keep reordering itself Jul 1, 2020
@manojVivek manojVivek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 2, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 2, 2020
@manojVivek manojVivek moved this from New to Accepted in App Roadmap Jul 2, 2020
@manojVivek
Copy link
Collaborator

@jjavierdguezas Yeah you are right, the ordering is not taken care of when a device is dropped in the inactive list.

@TatisLois
Copy link

Hey 👋🏽

If this is a good first issue for a contributor I’ll like to take a crack at fixing this issue!

@manojVivek
Copy link
Collaborator

@TatisLois That would be awesome, assigning it to you! 🙌

@manojVivek
Copy link
Collaborator

@TatisLois Please join us on Gitter if you have any questions along the way - https://gitter.im/responsively-app/

@manojVivek
Copy link
Collaborator

@TatisLois, any updates on this one?

It is perfectly alright if you got busy, just let us know. :)

jjavierdguezas added a commit to jjavierdguezas/responsively-app that referenced this issue Aug 26, 2020
@jjavierdguezas
Copy link
Contributor Author

It's been like two months so I gave it a try (and it was tricky),
@TatisLois don't worry there are (and will be) more issues to solve. looking forward for your contributions in the future! 💪🏻

@jjavierdguezas jjavierdguezas removed the help wanted Extra attention is needed label Aug 26, 2020
@jjavierdguezas jjavierdguezas moved this from In progress to In PR in App Roadmap Aug 26, 2020
@manojVivek manojVivek removed the good first issue Good for newcomers label Aug 27, 2020
@manojVivek manojVivek added this to the v0.12.0 milestone Aug 27, 2020
@jjavierdguezas jjavierdguezas moved this from In PR to Ready for Release in App Roadmap Aug 27, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.12.0 in App Roadmap Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
App Roadmap
  
Release v0.12.0
Development

Successfully merging a pull request may close this issue.

3 participants