Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a light theme for the App Interface and have a switch in the preferences. #238

Closed
saltcod opened this issue Jul 2, 2020 · 9 comments · Fixed by #434
Closed

Add a light theme for the App Interface and have a switch in the preferences. #238

saltcod opened this issue Jul 2, 2020 · 9 comments · Fixed by #434
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@saltcod
Copy link

saltcod commented Jul 2, 2020

Hey guys! Just discovered this and it looks amazing!

Sadly, my eyes prevent me from being able to work against a dark backgrounds, so I was keen to see if there was a Light mode. The Switch Color Scheme button doesn't seem to do anything when I click it — should that toggle the whole app from light to dark?

Thanks and fantastic work!

@jjavierdguezas
Copy link
Contributor

hi @saltcod ,
I think that Switch Color Scheme feature is for the devices view, not for Responsively App windows, for example go to https://nandovieira.com/supporting-dark-mode-in-web-content and click the switch button (you will notice the change, because that website handle OS color scheme)

darkmode2

what OS are you using?
In Windows I notice that also the Application Menu changes..

Maybe you want a Light theme feature
cc: @manojVivek

@saltcod
Copy link
Author

saltcod commented Jul 2, 2020

aaah I see. Yeah it seems I do have a feature request then =)

@manojVivek
Copy link
Collaborator

@jjavierdguezas Yeah that is right, we need to add a light theme for app.

@saltcod Thanks for reporting. We will add this to the roadmap.

@manojVivek manojVivek added enhancement New feature or request help wanted Extra attention is needed labels Jul 2, 2020
@manojVivek manojVivek changed the title Switch color scheme doesn't do anything? Add light theme for the App Interface and have a switch in the preferences. Jul 2, 2020
@manojVivek manojVivek changed the title Add light theme for the App Interface and have a switch in the preferences. Add a light theme for the App Interface and have a switch in the preferences. Jul 2, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Jul 2, 2020
@manojVivek manojVivek moved this from New to Accepted in App Roadmap Jul 2, 2020
@Grafikart
Copy link
Contributor

@manojVivek Where would you put this setting ? I could take a look at it (I would put the setting in the setting sidebar to avoid an extra button close to the address bar).

@manojVivek
Copy link
Collaborator

@manojVivek
Copy link
Collaborator

Do you want me to assign this to you?

@Grafikart
Copy link
Contributor

I thought it would be simple but changing the createMuiTheme type to "light" doesn't seem to work so I'm not sur I will have the time if it's more complex.

@manojVivek
Copy link
Collaborator

Yes, I understand. Thanks for checking 👍

@jzabala jzabala self-assigned this Aug 20, 2020
@jzabala jzabala removed the help wanted Extra attention is needed label Aug 20, 2020
@jjavierdguezas jjavierdguezas moved this from Accepted to In PR in App Roadmap Aug 31, 2020
@manojVivek manojVivek added this to the v0.13.0 milestone Sep 4, 2020
@jjavierdguezas jjavierdguezas moved this from In PR to Ready for Release in App Roadmap Sep 17, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.13.0 in App Roadmap Sep 22, 2020
@saltcod
Copy link
Author

saltcod commented Sep 24, 2020

Been meaning to come by for a few weeks and say THANK YOU for releasing the light version of this! I love it — fantastic work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.13.0
Development

Successfully merging a pull request may close this issue.

5 participants