Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a border to the devices based on a switch in the user preference. #290

Closed
dv336699 opened this issue Jul 8, 2020 · 4 comments · Fixed by #299
Closed

Add a border to the devices based on a switch in the user preference. #290

dv336699 opened this issue Jul 8, 2020 · 4 comments · Fixed by #299
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dv336699
Copy link
Contributor

dv336699 commented Jul 8, 2020

Is there an option to set the background color to something other than the gray one?

One of my projects use the same hex color as the app making it hard to see the edge of each page.

Thanks

@manojVivek
Copy link
Collaborator

@diego-vieira We have an issue open for having a light theme for the app #238. But that is a bigger change and will take time.

But meanwhile, we can add some kind of device border highlighting like in the below screenshot. Let us know if that will work for you.

Screenshot 2020-07-08 at 5 15 37 PM

@manojVivek manojVivek added the more info needed Need more details about the issue label Jul 8, 2020
@dv336699
Copy link
Contributor Author

dv336699 commented Jul 8, 2020

@manojVivek that'd be perfect. Very kind of you to reply so quickly. Many thanks

@manojVivek manojVivek changed the title Background color Add a border to the devices based on a switch in the user preference. Jul 8, 2020
@manojVivek manojVivek added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed more info needed Need more details about the issue labels Jul 8, 2020
@dv336699
Copy link
Contributor Author

dv336699 commented Jul 8, 2020

@manojVivek I can do this one, but I can't see a way to assign this issue to myself?

@manojVivek
Copy link
Collaborator

That is awesome, I'm assigning it to you! 🙌

You can just add a switch in the UserPreferences component and based on the value show a border. So that the users can selectively enable it.

Also, you can join us here if you get any questions along the way - https://gitter.im/responsively-app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants