Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unwanted 20px padding below the menu bar on Windows and Linux #457

Closed
manojVivek opened this issue Sep 17, 2020 · 2 comments · Fixed by #458
Closed

Remove the unwanted 20px padding below the menu bar on Windows and Linux #457

manojVivek opened this issue Sep 17, 2020 · 2 comments · Fixed by #458
Assignees
@MBakirci
Labels
enhancement New feature or request
Projects
App Roadmap
Milestone
v0.13.0

Comments

@manojVivek
Copy link
Collaborator

Remove the space shown in the below screenshot:
Screenshot 2020-09-17 at 8 01 51 AM
@manojVivek manojVivek added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 17, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Sep 17, 2020
@manojVivek manojVivek moved this from New to Higher-Priority Items in App Roadmap Sep 17, 2020
MBakirci added a commit to MBakirci/responsively-app that referenced this issue Sep 17, 2020
@MBakirci
fixed responsively-org#457
1f88111
@jjavierdguezas jjavierdguezas linked a pull request Sep 17, 2020 that will close this issue
fixed #457 #458
Merged
@jjavierdguezas jjavierdguezas moved this from Higher-Priority Items to In PR in App Roadmap Sep 17, 2020
@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Sep 17, 2020 •
edited

This is also happening in Ubuntu

image

@jjavierdguezas jjavierdguezas mentioned this issue Sep 17, 2020
Merged
@jjavierdguezas jjavierdguezas removed good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2020
@MBakirci
Copy link
Contributor

For now the line os.platform() === 'darwin' ? '20px 0 5px' : '0 0 0'is added to fix this issue on Windows and Linux(at least Ubuntu).

jjavierdguezas added a commit that referenced this issue Sep 17, 2020
@jjavierdguezas
Merge pull request #458 from MBakirci/windows-menubar-padding
f5c3300 
fixed #457
@jjavierdguezas jjavierdguezas changed the title Remove the unwanted 20px padding below the menu bar on Windows Remove the unwanted 20px padding below the menu bar on Windows and Linux Sep 17, 2020
@jjavierdguezas jjavierdguezas moved this from In PR to Ready for Release in App Roadmap Sep 17, 2020
@manojVivek manojVivek added this to the v0.13.0 milestone Sep 18, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.13.0 in App Roadmap Sep 22, 2020
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBakirci MBakirci

Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.13.0
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

fixed #457 MBakirci/responsively-app
3 participants
@manojVivek @MBakirci @jjavierdguezas