Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Open responsively app maximized #495

Closed
jjavierdguezas opened this issue Oct 5, 2020 · 0 comments · Fixed by #500
Closed

[Improvement] Open responsively app maximized #495

jjavierdguezas opened this issue Oct 5, 2020 · 0 comments · Fixed by #500
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Oct 5, 2020

I noticed that Responsively windows try to cover the screen height and width on start

const {width, height} = electron.screen.getPrimaryDisplay().workAreaSize;
const iconPath = path.resolve(__dirname, '../resources/icons/64x64.png');
mainWindow = new BrowserWindow({
show: false,
width,
height,
webPreferences: {
nodeIntegration: true,
nodeIntegrationInWorker: true,
webviewTag: true,
enableRemoteModule: true,
},
titleBarStyle: 'hidden',
icon: iconPath,
});

But (at least on windows) it leaves gaps:
image

Maybe it's just me, but I'd like more if it always opens maximized

We can use maximize() function

@manojVivek manojVivek added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2020
@manojVivek manojVivek added this to New in App Roadmap via automation Oct 5, 2020
@manojVivek manojVivek moved this from New to Higher-Priority Items in App Roadmap Oct 5, 2020
@jjavierdguezas jjavierdguezas self-assigned this Oct 5, 2020
@jjavierdguezas jjavierdguezas removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2020
@jjavierdguezas jjavierdguezas moved this from Higher-Priority Items to In progress in App Roadmap Oct 5, 2020
jjavierdguezas added a commit that referenced this issue Oct 5, 2020
@jjavierdguezas jjavierdguezas moved this from In progress to In PR in App Roadmap Oct 5, 2020
sidthesloth92 pushed a commit that referenced this issue Oct 5, 2020
* Start responsively maximized
Resolves #495

* fix eslint errors
@jjavierdguezas jjavierdguezas moved this from In PR to Ready for Release in App Roadmap Oct 5, 2020
@manojVivek manojVivek added this to the v0.14.0 milestone Oct 6, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.14.0 in App Roadmap Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
App Roadmap
  
Release v0.14.0
Development

Successfully merging a pull request may close this issue.

2 participants