Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'users' badge for edge extension in readme.md #1079

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

prajjwalyd
Copy link
Contributor

✨ Pull Request

added 'users' badge for edge extension in readme.md

ℹ️ About the PR

The 'users' badge was missing for the edge's extension... Here's my small contribution!
image

added 'users' badge for edge extension
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

README.md Outdated
@@ -103,7 +103,7 @@ Install the handy browser extension to easily send links from your browser to th

- [Download for Chrome](https://chrome.google.com/webstore/detail/responsively-helper/jhphiidjkooiaollfiknkokgodbaddcj) <a href="https://chrome.google.com/webstore/detail/responsively-helper/jhphiidjkooiaollfiknkokgodbaddcj" target="_blank"><img alt="Chrome Web Store" src="https://img.shields.io/chrome-web-store/users/jhphiidjkooiaollfiknkokgodbaddcj"></a>
- [Download for Firefox](https://addons.mozilla.org/en-US/firefox/addon/responsively-helper/) <a href="https://addons.mozilla.org/en-US/firefox/addon/responsively-helper/" target="_blank"><img alt="Mozilla Add-on" src="https://img.shields.io/amo/users/responsively-helper"></a>
- [Download for Edge](https://microsoftedge.microsoft.com/addons/detail/responsively-helper/ooiejjgflcgkbbehheengalibfehaojn)
- [Download for Edge](https://microsoftedge.microsoft.com/addons/detail/responsively-helper/ooiejjgflcgkbbehheengalibfehaojn) <a href="https://microsoftedge.microsoft.com/addons/detail/responsively-helper/ooiejjgflcgkbbehheengalibfehaojn" target="_blank"><img alt="Edge Add-on" src="https://img.shields.io/badge/users-4k-yellow"></a>
Copy link
Collaborator

@manojVivek manojVivek Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to get the current users count like in the other badges?

Otherwise, it is most likely to go stale over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @manojVivek , I found a way to get a dynamic user badge for the edge extension... but the problem is that it shows the exact user count ('users: 4376') instead of something like - 'users: 4k'.
Here is the link-
https://img.shields.io/badge/dynamic/json?label=users&query=%24.activeInstallCount&url=https%3A%2F%2Fmicrosoftedge.microsoft.com%2Faddons%2Fgetproductdetailsbycrxid%2Fooiejjgflcgkbbehheengalibfehaojn

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be alright.

adds a dynamic badge to the edge's extension
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prajjwalyd Thank you so much for this contribution! Looking forward to more like this.

@manojVivek manojVivek merged commit 647f5e9 into responsively-org:main Sep 17, 2023
4 checks passed
@manojVivek
Copy link
Collaborator

@all-contributors Please add @prajjwalyd for docs.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @prajjwalyd! 🎉

@prajjwalyd prajjwalyd deleted the prajjwalyd-readme-update branch October 21, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants