Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to edit a custom device's name #1081

Merged
merged 2 commits into from Sep 19, 2023
Merged

Add ability to edit a custom device's name #1081

merged 2 commits into from Sep 19, 2023

Conversation

lyncasterc
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

ℹ️ About the PR

In DeviceDetailsModal.tsx:

  • only disable name input if it is not a custom device.
  • remove the note informing user that they can not change the custom device's name
  • Disallow the ability to change a custom device's name to an existing device's name in the handleAddDevice function
    • I added this because it is already the existing behavior when adding a new custom device, and because it creates issues when checking/unchecking custom devices with the same name because the logic in DeviceLabel.tsx is still using name instead of id.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@lyncasterc lyncasterc mentioned this pull request Sep 18, 2023
Closed
manojVivek
manojVivek approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!
Thank you so much for the contribution and looking forward to more!

@manojVivek manojVivek merged commit c9c2d43 into responsively-org:main Sep 19, 2023
4 checks passed
@manojVivek
Copy link
Collaborator

@all-contributors Please add @lyncasterc for code.

@allcontributors allcontributors bot mentioned this pull request Sep 19, 2023
Merged
@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @lyncasterc! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojVivek manojVivek manojVivek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Ability to edit device name Support device renaming
3 participants
@lyncasterc @CLAassistant @manojVivek