added useDetectionOutside for bookmark #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manojVivek
approved these changes
Sep 23, 2023
|
@all-contributors Please add @negar-75 for code. |
|
I've put up a pull request to add @negar-75! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
this is not an opened issue, this is the small feature when I used with the app I found out
ℹ️ About the PR
I found out when you click on bookmark icon and the menu opens, it will never close unless you click the icon again and it was a little bit annoying to me. so I added a function to detect outside click and the close the menu not just by clicking on icon!
🖼️ Testing Scenarios / Screenshots
bandicam-2023-09-21-22-30-55-351_fW2QA6rF.mp4