Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1111: Screenshot location input remains white in dark mode In Settings Dialog #1112

Conversation

NishidhJain
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

Resolves <#1111 >

ℹ️ About the PR

I have added tailwind class to change the input background in dark mode. I have also added max-width to settings dialog so it does not grow too long on larger screens.

🖼️ Testing Scenarios / Screenshots

Dark Mode

image

Light Mode

Screenshot 2023-10-05 at 12 59 55 PM

Tested for both light & dark mode

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ NishidhJain
❌ Nishidh Jain


Nishidh Jain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution. Looking forward to more like this! 🎉

@manojVivek manojVivek linked an issue Oct 6, 2023 that may be closed by this pull request
@manojVivek manojVivek merged commit f33bd5a into responsively-org:main Oct 6, 2023
3 of 4 checks passed
@manojVivek
Copy link
Collaborator

@all-contributors Please add @NishidhJain for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @NishidhJain! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshot location input remains white in dark mode In Settings
4 participants