Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #1075 #1145

Closed
wants to merge 7 commits into from
Closed

Conversation

astuanax
Copy link
Contributor

@astuanax astuanax commented Nov 1, 2023

✨ Pull Request

📓 Referenced Issue

#1075 Proposes new features for accessibility.

ℹ️ About the PR

This PR adds a menu, dropdown, to apply XSLT filters to one of the webviews to simulate the experience of people with visual impairments and color deficiencies.

Things to consider:

  • Size of the menu and icons (long? had to remove overflow-hidden on the webview element)
  • Should we apply it to all screens? (How to do that??)

Looking forward to the comments.

🖼️ Testing Scenarios / Screenshots

The menu can be applied to any websites.
Here is a video on how to test:
https://github.com/responsively-org/responsively-app/assets/1730624/9986dc57-193a-4783-b093-aaed16611691

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ astuanax
✅ ParamBirje
❌ Len


Len seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@astuanax astuanax closed this Nov 2, 2023
@astuanax astuanax deleted the accessibility1075 branch November 2, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants