Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility UI polish & Global toolbar controls #1160

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Accessibility UI polish & Global toolbar controls #1160

merged 7 commits into from
Nov 14, 2023

Conversation

manojVivek
Copy link
Collaborator

This PR contains:

  • Minor UI polish for asthetics.
  • Code refactoring for better reuse of code.
  • Applied filter is persisted across page navigations.
  • Global controls to apply filters to all devices.

Screenscast:
https://github.com/responsively-org/responsively-app/assets/1283424/e8cedead-6265-4d78-ac34-3017f3f0eb07

@astuanax
Copy link
Contributor

astuanax commented Nov 14, 2023 •
edited

Looks good, testing and fixing some minor issues.

@manojVivek manojVivek merged commit 598892e into main Nov 14, 2023
5 checks passed
@manojVivek manojVivek deleted the accessibility-polish branch November 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astuanax astuanax astuanax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manojVivek @astuanax