Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides & Rulers #1162

Merged
merged 20 commits into from
Dec 9, 2023
Merged

Guides & Rulers #1162

merged 20 commits into from
Dec 9, 2023

Conversation

astuanax
Copy link
Contributor

@astuanax astuanax commented Nov 14, 2023

✨ Pull Request

📓 Referenced Issue

#1149 Adds persistent guides and rulers

ℹ️ About the PR

  • Adds vertical and horizontal rulers
  • Adds persistent guides which can be dragged, vertical and horizontal
  • Adds keyboard short alt-r to show/hide rulers for all webviews

🖼️ Testing Scenarios / Screenshots

  • Test with different screens resolutions
  • Test with different views: single/many
  • Close and reopen application after creating guides: they should remain visible
  • Switch between night mode /regular mode

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such an essential utility and great work implementing it. 🚀

Did review the code and also a round of testing and added the observations as comments on the code.

desktop-app/src/store/migrations.ts Outdated Show resolved Hide resolved
desktop-app/src/store/index.ts Show resolved Hide resolved
desktop-app/src/store/index.ts Outdated Show resolved Hide resolved
- default empty array
- remove default padding
- align left px value ofr rulers
- updated keyboard shortcut
missing overflow
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great now!

@manojVivek manojVivek merged commit f665a8f into responsively-org:main Dec 9, 2023
4 checks passed
@sam98brown
Copy link

Is this feature usable?

@manojVivek
Copy link
Collaborator

It is not live yet, waiting on a related bug to be addressed. It should be out in a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants