Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show ctrl as mod button in shortcut modal for windows devices #1187

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

surajbobade
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

Fixes: #1185

ℹ️ About the PR

Currently for all the platform, shortcut mod is key visible as '⌘'. It should be Ctrl for windows devices.

🖼️ Testing Scenarios / Screenshots

Screenshot 2024-01-19 at 11 02 37 PM

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@surajbobade surajbobade changed the title fix: show ctrl as mod button in shortcut modal fix: show ctrl as mod button in shortcut modal for windows devices Jan 19, 2024
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking care of this so quickly! 🚀

@manojVivek manojVivek merged commit ba4dd5e into responsively-org:main Jan 22, 2024
4 checks passed
@manojVivek
Copy link
Collaborator

@all-contributors Please add @surajbobade for code.

Copy link
Contributor

@manojVivek

I've put up a pull request to add @surajbobade! 🎉

@surajbobade
Copy link
Contributor Author

Thank you so much for taking care of this so quickly! 🚀

Most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ctrl key icons in shortcuts window
3 participants