-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
focus specific device in and out #214
Conversation
desktop-app/app/actions/browser.js
Outdated
@@ -284,7 +292,7 @@ export function changeDrawerOpenState(newOpenState) { | |||
}; | |||
} | |||
|
|||
export function setPreviewLayout(newLayout) { | |||
export function setPreviewLayout(newLayout, focusedDeviceId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the focusedDeviceId
arg ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
<TabList> | ||
{devices | ||
{/* {devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls remove the commented code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done Manoj
desktop-app/app/reducers/browser.js
Outdated
@@ -321,6 +330,14 @@ export default function browser( | |||
: device | |||
); | |||
return {...state, devices: newDevicesList}; | |||
// case DEVICE_FOCUS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please delete this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done Manoj
… into feature/focus-device
No description provided.