Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation when opening the Drawer #254

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Fix animation when opening the Drawer #254

merged 2 commits into from
Jul 3, 2020

Conversation

vlazaroes
Copy link
Contributor

Previously, width was used in animation, this caused strange animation when opening the Drawer.

This solution uses the property of margin and achieves smoother animation.

Previously, width was used in animation, this caused strange animation when opening the Drawer.
@manojVivek
Copy link
Collaborator

@vlazaroes This is wonderful, can you please resolve the merge conflicts?

@vlazaroes
Copy link
Contributor Author

@manojVivek Solved.

@manojVivek
Copy link
Collaborator

@vlazaroes Great, thanks for making it better. Merging this in now, looking forward to more collaboration like this! 🙌

@manojVivek manojVivek merged commit effaf09 into responsively-org:master Jul 3, 2020
@manojVivek manojVivek added this to the v0.6.0 milestone Jul 3, 2020
@manojVivek manojVivek added this to In PR in App Roadmap Jul 3, 2020
@manojVivek
Copy link
Collaborator

@all-contributors Please add @vlazaroes for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @vlazaroes! 🎉

@manojVivek
Copy link
Collaborator

manojVivek commented Jul 3, 2020

@vlazaroes Two things:

  1. Can you let us know your Twitter handler? We would love to give a shout out for your work from our twitter handle.
  2. Please join our community on Gitter - https://gitter.im/responsively-app/, for any discussions in the future.

@manojVivek manojVivek moved this from In PR to Ready for Release in App Roadmap Jul 6, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v.0.6.0 in App Roadmap Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
App Roadmap
  
Release v.0.6.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants