Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade desktop app packages #335

Merged

Conversation

ruisaraiva19
Copy link
Contributor

@ruisaraiva19 ruisaraiva19 commented Jul 19, 2020

  • Remove package-lock.json in favor of yarn.lock
  • Upgrade Husky and use lint-staged with it
  • Upgrade sass-loader and migrate from node-sass to sass (dart-sass) as recommended in the sass-loader v9.0.0 release

@manojVivek
Copy link
Collaborator

@ruisaraiva19 Sorry for the delay in merging this. 🙇‍♂️
Doing it now and thanks for the package upgrades.

@manojVivek manojVivek added this to the v0.13.0 milestone Sep 2, 2020
@manojVivek manojVivek added this to In PR in App Roadmap Sep 2, 2020
@manojVivek manojVivek merged commit 757c61b into responsively-org:master Sep 2, 2020
@manojVivek
Copy link
Collaborator

@all-contributors Please add @ruisaraiva19 for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @ruisaraiva19! 🎉

@manojVivek
Copy link
Collaborator

@ruisaraiva19

  • Can you let us know your Twitter handle? We would love to give a shout out for your work from our twitter account.

  • Please join our community on Slack, for any discussions.

Looking forward to more collaborations in the future! 💪🏻

@ruisaraiva19 ruisaraiva19 deleted the chore/upgrade-packages branch September 4, 2020 06:19
@manojVivek manojVivek moved this from In PR to Ready for Release in App Roadmap Sep 22, 2020
@manojVivek manojVivek moved this from Ready for Release to Release v0.13.0 in App Roadmap Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
App Roadmap
  
Release v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants