-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser sync mirroring bug fixes #339
Conversation
let browserSyncOptions; | ||
|
||
if (!browserSyncOptions) { | ||
browserSyncOptions = ipcRenderer.sendSync('request-browser-sync'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esprush Can you convert this to ipcRenderer.invoke
instead of sendSync
?
This is going to block the UI thread until the request is processed which is not right.
ui: false, | ||
}, | ||
(err, bs) => { | ||
resolve(bs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be like below:
if (err) {
return reject(err);
}
resolve(bs);
No description provided.