Watching .css and .js files using browser sync #373
Conversation
desktop-app/app/utils/browserSync.js
Outdated
| await initInstance(); | ||
| } | ||
| } | ||
|
|
||
| export function watchFiles(fileDir) { | ||
| filesWatcher = browserSyncEmbed | ||
| .watch([`${fileDir}/*.html`, `${fileDir}/**/**.js`]) |
There was a problem hiding this comment.
@esprush
If we are watching all *.js and all *.css in all sub folders, why not to do the same with *.html?
There was a problem hiding this comment.
@jjavierdguezas made it this way since html might depend on css and js in subfolders.
whereas html file is always one which is selected in the address bar. so thought watching subfolders for html is not needed.
There was a problem hiding this comment.
I think we should only watch the currently loaded .html file, as the other HTML files may not be related to the current page.
There was a problem hiding this comment.
@esprush @jjavierdguezas Merging this now. Let's address any concerns in a new PR.
| @@ -305,30 +307,19 @@ const createWindow = async () => { | |||
| onResize(); | |||
| }); | |||
|
|
|||
| const watcher = new chokidar.FSWatcher(); | |||
There was a problem hiding this comment.
should we uninstall chokidar package right?
There was a problem hiding this comment.
yes @jjavierdguezas . removed
There was a problem hiding this comment.
@manojVivek @jjavierdguezas made further updates
- watch only specific html file
- check if the file is valid.
| @@ -305,30 +307,19 @@ const createWindow = async () => { | |||
| onResize(); | |||
| }); | |||
|
|
|||
| const watcher = new chokidar.FSWatcher(); | |||
There was a problem hiding this comment.
yes @jjavierdguezas . removed
desktop-app/app/utils/browserSync.js
Outdated
| await initInstance(); | ||
| } | ||
| } | ||
|
|
||
| export function watchFiles(fileDir) { | ||
| filesWatcher = browserSyncEmbed | ||
| .watch([`${fileDir}/*.html`, `${fileDir}/**/**.js`]) |
There was a problem hiding this comment.
@jjavierdguezas made it this way since html might depend on css and js in subfolders.
whereas html file is always one which is selected in the address bar. so thought watching subfolders for html is not needed.
manojVivek
changed the title
@manojVivek @jjavierdguezas hot reloading for local files using browserSync. added support for js,html and css.