Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the App's crash page #411

Merged
merged 13 commits into from Aug 31, 2020
Merged

Improve the App's crash page #411

merged 13 commits into from Aug 31, 2020

Conversation

gorogoroumaru
Copy link
Contributor

Fix #407

We can't copy stack trace or error info in the app's crash page.
So, I added the functionality.

@jjavierdguezas
Copy link
Contributor

hi @gorogoroumaru can you share a screenshot of how this will look like?

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Aug 21, 2020

I think this is a nice feature to have:

And if possible add a link that can take the user to the GitHub create issue page with the content prefilled. - @manojVivek

there are packages that can help with that, for example electron-util and new-github-issue-url

@gorogoroumaru
Copy link
Contributor Author

gorogoroumaru commented Aug 29, 2020

I'm sorry for fixing too late.
I had trouble when fixing.
This is the screenshot.

Screenshot_20200829_104926

@gorogoroumaru
Copy link
Contributor Author

Thanks, I applied your suggested changes.
This is the screenshot.

Screenshot_20200830_213622

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Aug 30, 2020

Thanks, I applied your suggested changes.
This is the screenshot.

Screenshot_20200830_213622

thanks @gorogoroumaru , two things to discuss here:

  • should we increase the width of the textareas? (maybe set it to a % of the viewport)
  • should we use buttons with the blue background as they are in the rest of the app?
    @manojVivek @jzabala

@jzabala
Copy link
Contributor

jzabala commented Aug 31, 2020

thanks @gorogoroumaru , two things to discuss here:

  • should we increase the width of the textareas? (maybe set it to a % of the viewport)
  • should we use buttons with the blue background as they are in the rest of the app?
    @manojVivek @jzabala

Yeah, there are a lot of space available. I think bigger boxes will look better.

@gorogoroumaru
Copy link
Contributor Author

Thank you!
This is the screenshot of the latest fix.

Screenshot_20200831_224920

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Aug 31, 2020

Thank you!
This is the screenshot of the latest fix.

Screenshot_20200831_224920

@gorogoroumaru Maybe we didn't explain ourselves well, we don't want three textareas (one of them with the information of the others), we need two wide text areas and use the same styles for the buttons

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Aug 31, 2020

Hi @gorogoroumaru I made some changes and now it looks like this

image

and the info is filled and formatted when creating new issue

Copy link
Contributor

@jjavierdguezas jjavierdguezas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorogoroumaru @manojVivek @jzabala I think now this is ready to merge

Copy link
Contributor

@jzabala jzabala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great 🥳

Thank you very much for you hard work @gorogoroumaru.

@jzabala jzabala merged commit 46323ab into responsively-org:master Aug 31, 2020
@jzabala
Copy link
Contributor

jzabala commented Aug 31, 2020

@all-contributors Please add @gorogoroumaru for code.

@allcontributors
Copy link
Contributor

@jzabala

I've put up a pull request to add @gorogoroumaru! 🎉

@jzabala
Copy link
Contributor

jzabala commented Aug 31, 2020

@gorogoroumaru

  • Can you let us know your Twitter handle? We would love to give a shout out for your work from our twitter account.

  • Please join our community on Slack, for any discussions.

Looking forward to more collaborations in the future! 💪🏻

@gorogoroumaru
Copy link
Contributor Author

Thank you everyone for a lot of support!
My twitter handle name is also @gorogoroumaru.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the App's crash page to have instructions on how to report the issue.
4 participants