-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh rewrite of the app which eliminates usage of deprecated Electron APIs and improved setup and framework to be more developer friendly #720
Conversation
This is great @manojVivek ! I am getting errors on
|
I have created an issue with the list of features here: #724 Please feel free to add/remove items in the list. |
This error can be ignored (by clicking close at the bottom). This happens when the URL redirects to a different URL. More info here: electron/electron#24171 (comment) Tried a few things to suppress the error (Like adding ErrorBoundaries, catching errors from webview, etc) but no luck yet. |
These errors are from browser sync and doesn't seem to be blockers, so added a workaround to suppress these and pushed a commit. |
@jjavierdguezas It has reached a point where we can do beta releases as it's complete with all features marked as beta required. I'm merging this and testing the release of beta version of app using GitHub actions. Please feel free to leave your review, and I'll address them in a future PR. |
✨ Pull Request
ℹ️ About the PR
I have rewritten the app (not feature complete yet) with basic functionality, removing the deprecated Electron API which were preventing us from upgrading the Chromium version.
This uses latest version of electron,
tailwindcss
andredux-toolkit
.I know taking the route of rewriting the app is not very clever, but the previous implementation is so intertwined with the deprecated APIs that it is comparatively more difficult to fix that one.
Please let me know if you have any thoughts.
Implements part of #724