Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh rewrite of the app which eliminates usage of deprecated Electron APIs and improved setup and framework to be more developer friendly #720

Merged
merged 50 commits into from
Oct 16, 2022

Conversation

manojVivek
Copy link
Collaborator

@manojVivek manojVivek commented Sep 2, 2022

✨ Pull Request

ℹ️ About the PR

I have rewritten the app (not feature complete yet) with basic functionality, removing the deprecated Electron API which were preventing us from upgrading the Chromium version.

This uses latest version of electron, tailwindcss and redux-toolkit.

I know taking the route of rewriting the app is not very clever, but the previous implementation is so intertwined with the deprecated APIs that it is comparatively more difficult to fix that one.

Please let me know if you have any thoughts.

Implements part of #724

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Sep 5, 2022

This is great @manojVivek !
It would be good to put somewhere which features have been migrated, which ones are missing and which are the priorities.

I am getting errors on postinstall command execution:

ERROR in ./node_modules/browser-sync-ui/lib/plugins/network-throttle/network-throttle.js 91:36-92
Module not found: Error: Can't resolve 'browser-sync/lib/server/utils' in 'C:\root\ResponsivelyApp\desktop-app-rewrite\desktop-app-rewrite\node_modules\browser-sync-ui\lib\plugins\networ
k-throttle'
 @ ./node_modules/browser-sync-ui/lib/plugins/network-throttle/network-throttle.plugin.js 1:22-51
 @ ./node_modules/browser-sync-ui/lib/UI.js 18:24-85
 @ ./node_modules/browser-sync-ui/index.js 3:18-37
 @ ./node_modules/browser-sync/dist/browser-sync.js 23:8-34
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/cli/command.init.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"command.init.js","sourceRoot":"","sources":["../../lib/cli/command.init.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb,IAAI,IAAI,GAAG,OAAO,CAAC,YAAY,CAAC,CAAC;AAE
jC;;;;;;;GAOG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,IAAI;IAC1B,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,CAAC,EAAE,CAAC,CAAC;AAC5C,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/cli/ sync ^\.\/command\..*$ ./command.init.js.map
 @ ./node_modules/browser-sync/dist/bin.js 137:14-59
 @ ./node_modules/browser-sync/dist/cli/transforms/handleHostOption.js 4:14-34
 @ ./node_modules/browser-sync/dist/cli/cli-options.js 18:27-67
 @ ./node_modules/browser-sync/dist/public/init.js 4:22-51
 @ ./node_modules/browser-sync/dist/index.js 316:20-44
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/cli/command.recipe.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"command.recipe.js","sourceRoot":"","sources":["../../lib/cli/command.recipe.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AACb,IAAI,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,CAAC
,MAAM,CAAC;AAEzC;;;;;;;;GAQG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,IAAI;IAC1B,IAAI,IAAI,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC;IAC3B,IAAI,EAAE,GAAG,OAAO,CAAC,UAAU,CAAC,CAAC;IAC7B,IAAI,KAAK,GAAG,IAAI,CAAC
,GAAG,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACpC,IAAI,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;IAC7C,IAAI,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IAEjC,IAAI,UAAU,GAAG;QACb,IA
AI,IAAI,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC,CAAC;QACrD,MAAM,CAAC,IAAI,CACP,sEAAsE,CACzE,CAAC;QACF,IAAI,CAAC,OAAO,CAAC,UAAS,IAAI;YACtB,OAAO,CAAC,GAAG,CAA
C,MAAM,GAAG,IAAI,CAAC,CAAC;QAC/B,CAAC,CAAC,CAAC;IACP,CAAC,CAAC;IAEF,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE;QACf,MAAM,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;QACxC,UAAU,EAAE,CAAC;QACb,OAAO,IAAI,CAAC,EAAE,
EAAE,CAAC;KACpB;IAED,IAAI,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,IAAI,EAAE;QAC5B,UAAU,EAAE,CAAC;QACb,OAAO,IAAI,CAAC,EAAE,EAAE,CAAC;KACpB;IAED,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;IAC
jB,IAAI,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC;IAC3B,IAAI,MAAM,GAAG,KAAK,CAAC,MAAM;QACrB,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC;QAC5B,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,
GAAG,EAAE,EAAE,KAAK,CAAC,CAAC;IACtC,IAAI,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;IAEjD,IAAI,EAAE,CAAC,UAAU,CAAC,MAAM,CAAC,EAAE;QACvB,OAAO,IAAI,CAAC,EAAE,CACV,IAA
I,KAAK,CAAC,yDAAyD,CAAC,CACvE,CAAC;KACL;IAED,IAAI,EAAE,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE;QAC1B,EAAE,CAAC,IAAI,CAAC,SAAS,EAAE,MAAM,EAAE,UAAS,GAAG;YACnC,IAAI,GAAG,EAAE;gBACL,IAAI,CAAC,EAAE,CAA
C,GAAG,CAAC,CAAC;aAChB;iBAAM;gBACH,MAAM,CAAC,IAAI,CAAC,8BAA8B,EAAE,MAAM,CAAC,CAAC;gBACpD,MAAM,CAAC,IAAI,CACP,yDAAyD,CAC5D,CAAC;gBACF,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC;aACjB;QACL,CAAC,CA
AC,CAAC;KACN;SAAM;QACH,MAAM,CAAC,IAAI,CACP,gEAAgE,EAChE,KAAK,CACR,CAAC;QACF,UAAU,EAAE,CAAC;QACb,IAAI,CAAC,EAAE,EAAE,CAAC;KACb;AACL,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/cli/ sync ^\.\/command\..*$ ./command.recipe.js.map
 @ ./node_modules/browser-sync/dist/bin.js 137:14-59
 @ ./node_modules/browser-sync/dist/cli/transforms/handleHostOption.js 4:14-34
 @ ./node_modules/browser-sync/dist/cli/cli-options.js 18:27-67
 @ ./node_modules/browser-sync/dist/public/init.js 4:22-51
 @ ./node_modules/browser-sync/dist/index.js 316:20-44
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/cli/command.reload.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"command.reload.js","sourceRoot":"","sources":["../../lib/cli/command.reload.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb;;;;;;;;GAQG;AACH,MAAM,CAAC,OAAO,GAAG,UA
AS,IAAI;IAC1B,IAAI,KAAK,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC;IAC3B,IAAI,CAAC,KAAK,CAAC,GAAG,EAAE;QACZ,KAAK,CAAC,GAAG,GAAG,mBAAmB,GAAG,CAAC,KAAK,CAAC,IAAI,IAAI,IAAI,CAAC,CAAC;KAC1D;IACD,IAA
I,KAAK,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAAC;IACxC,IAAI,MAAM,GAAG,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC;IAC1D,IAAI,IAAI,GAAG,EAAE,MAAM,EAAE,QAAQ,
EAAE,CAAC;IAEhC,IAAI,KAAK,CAAC,KAAK,EAAE;QACb,IAAI,CAAC,IAAI,GAAG,KAAK,CAAC,KAAK,CAAC;KAC3B;IAED,IAAI,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,IAAI,EAAE,KAAK,CAAC,GAAG,CAAC,CAAC;IAExC,IAAI,MAAM,KAA
K,OAAO,EAAE;QACpB,OAAO,CAAC,GAAG,CAAC,4BAA4B,GAAG,GAAG,CAAC;KAClD;IAED,OAAO,CAAC,MAAM,CAAC;SACV,GAAG,CAAC,GAAG,EAAE,UAAS,GAAG;QAClB,GAAG,CAAC,EAAE,CAAC,MAAM,EAAE;YACX,IAAI,GAAG,CAAC,UAAU
,KAAK,GAAG,EAAE;gBACxB,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;aACtB;QACL,CAAC,CAAC,CAAC;IACP,CAAC,CAAC;SACD,EAAE,CAAC,OAAO,EAAE,UAAS,GAAG;QACrB,IAAI,GAAG,CAAC,IAAI,KAAK,cAAc,EAAE;Y
AC7B,GAAG,CAAC,OAAO,GAAG,6BAA6B,GAAG,KAAK,CAAC,GAAG,CAAC;SAC3D;QACD,OAAO,IAAI,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC;IACxB,CAAC,CAAC,CAAC;AACX,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/cli/ sync ^\.\/command\..*$ ./command.reload.js.map
 @ ./node_modules/browser-sync/dist/bin.js 137:14-59
 @ ./node_modules/browser-sync/dist/cli/transforms/handleHostOption.js 4:14-34
 @ ./node_modules/browser-sync/dist/cli/cli-options.js 18:27-67
 @ ./node_modules/browser-sync/dist/public/init.js 4:22-51
 @ ./node_modules/browser-sync/dist/index.js 316:20-44
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/cli/command.start.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"command.start.js","sourceRoot":"","sources":["../../lib/cli/command.start.ts"],"names":[],"mappings":";;AAAA,6BAA6B;AAC7B,2BAAgC;AAChC,yCAAmC;AACnC,kCAAkC;AAClC,+C
AAgD;AAChD,MAAM,CAAC,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAAC;AAEtC;;;;;;;;GAQG;AACH,mBAAwB,IAAI;IACxB,MAAM,KAAK,GAAG,eAAe,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;IAC9C,MAAM,GAAG,GAAG,KAAK,CAAC,G
AAG,IAAI,OAAO,CAAC,GAAG,EAAE,CAAC;IACvC,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,EAAE,cAAc,CAAC,CAAC;IACnD,IAAI,KAAK,GAAG,KAAK,CAAC;IAElB,IAAI,KAAK,CAAC,MAAM,EAAE;QACd,MAAM,SAAS,GAAG,IAAI
,CAAC,OAAO,CAAC,GAAG,EAAE,KAAK,CAAC,MAAM,CAAC,CAAC;QAClD,IAAI,IAAA,eAAU,EAAC,SAAS,CAAC,EAAE;YACvB,MAAM,IAAI,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC;YAChC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,EAAE,EAAE,IA
AI,EAAE,KAAK,CAAC,CAAC;SACpC;aAAM;YACH,KAAK,CAAC,IAAI,CACN,IAAI,EACJ,IAAI,KAAK,CAAC,uBAAuB,KAAK,CAAC,MAAM,aAAa,CAAC,EAC3D,IAAI,CAAC,EAAE,CACV,CAAC;SACL;KACJ;SAAM;QACH,IAAI,IAAA,eAAU,EAAC
,QAAQ,CAAC,EAAE;YACtB,MAAM,GAAG,GAAG,OAAO,CAAC,QAAQ,CAAC,CAAC;YAC9B,IAAI,GAAG,CAAC,cAAc,CAAC,EAAE;gBACrB,OAAO,CAAC,GAAG,CAAC,4CAA4C,CAAC,CAAC;gBAC1D,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,EAAE,EA
AE,GAAG,CAAC,cAAc,CAAC,EAAE,KAAK,CAAC,CAAC;aACnD;SACJ;KACJ;IAED,OAAO,OAAO,CAAC,KAAK,CAAC;SAChB,MAAM,CAAC,KAAK,CAAC;SACb,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC,EAAE,CAAC,CAAC;AAC9B,CAAC;AA/BD,4BA+
BC;AAED;;;GAGG;AACH,SAAS,eAAe,CAAC,KAAK;IAC1B,OAAO;QACH,cAAc;QACd,eAAe;QACf,2BAA2B;KAC9B,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,KAAK,CAAC,EAAE,KA
AK,CAAC,CAAC;AACzD,CAAC;AAED;;;;;GAKG;AACH,SAAS,cAAc,CAAC,OAAO;IAC3B,OAAO,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE;QAC5C,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,C
AAC,CAAC;QAC3B,IAAI,OAAO,KAAK,KAAK,WAAW,EAAE;YAC9B,OAAO,GAAG,CAAC;SACd;QACD,GAAG,CAAC,GAAG,CAAC,GAAG,KAAK,CAAC;QACjB,OAAO,GAAG,CAAC;IACf,CAAC,EAAE,EAAE,CAAC,CAAC;AACX,CAAC;AAED;;;GAGG;AA
CH,SAAS,eAAe,CAAC,KAAK;IAC1B,IAAI,KAAK,CAAC,KAAK,IAAI,KAAK,CAAC,KAAK,CAAC,MAAM,EAAE;QACnC,KAAK,CAAC,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,MAAM,CAC5B,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,GAAG,CAAC,
MAAM,CAAC,IAAA,6BAAe,EAAC,IAAI,CAAC,CAAC,EAChD,EAAE,CACL,CAAC;KACL;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;;;;GAKG;AACH,SAAS,2BAA2B,CAAC,KAAK;IACtC,IAAI,KAAK,CAAC,KAAK,KAAK,KAAK,EAAE;QACvB,
OAAO,IAAA,kBAAM,EAAC,KAAK,CAAC;aACf,MAAM,CAAC,OAAO,CAAC;aACf,IAAI,EAAE,CAAC;KACf;IACD,OAAO,KAAK,CAAC;AACjB,CAAC"}
 @ ./node_modules/browser-sync/dist/cli/ sync ^\.\/command\..*$ ./command.start.js.map
 @ ./node_modules/browser-sync/dist/bin.js 137:14-59
 @ ./node_modules/browser-sync/dist/cli/transforms/handleHostOption.js 4:14-34
 @ ./node_modules/browser-sync/dist/cli/cli-options.js 18:27-67
 @ ./node_modules/browser-sync/dist/public/init.js 4:22-51
 @ ./node_modules/browser-sync/dist/index.js 316:20-44
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/exit.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"exit.js","sourceRoot":"","sources":["../../lib/public/exit.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb;;;GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,WAAW;IACjC,SAAS,IAA
I;QACT,IAAI,WAAW,CAAC,MAAM,EAAE;YACpB,WAAW,CAAC,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;YACxC,WAAW,CAAC,OAAO,EAAE,CAAC;SACzB;IACL,CAAC;IAED,OAAO,IAAI,CAAC;AAChB,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./exit.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/init.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"init.js","sourceRoot":"","sources":["../../lib/public/init.ts"],"names":[],"mappings":";;AAAA,IAAI,CAAC,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAAC;AACpC,oDAAwD;AAExD;;;;;GAKG
;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,WAAW,EAAE,IAAI,EAAE,KAAK;IAC9C,OAAO;QACH;;WAEG;QACH,IAAI,IAAI,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC;QAEpD;;WAEG;QACH,IAAI,W
AAW,CAAC,MAAM,EAAE;YACpB,OAAO,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,CAAC,aAAa,IAAI,sBAAsB,CAAC,CAAC,CAAC;SACtE;QAED,qBAAqB;QACrB,IAAI,CAAC,MAAM,CAAC,OAAO,GAAG,KAAK,CAAC,OAAO,CAAC;QACpC,IAAI,CAAC
,MAAM,CAAC,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,GAAG,IAAI,OAAO,CAAC,GAAG,EAAE,CAAC;QAEnD,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,GAAG,IAAA,mBAAK,EAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAE1C,IAAI,MAAM,CAAC,MAAM,EA
AE;YACf,OAAO,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,CAAC,IAAA,yBAAW,EAAC,MAAM,CAAC,CAAC,CAAC,CAAC;SAClD;QAED,OAAO,WAAW,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,CAAC;IAC3C,CAAC,CAAC;AACN,CAAC,
CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./init.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/notify.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"notify.js","sourceRoot":"","sources":["../../lib/public/notify.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb;;;GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,WAAW;IACjC,OAAO
,UAAS,GAAG,EAAE,OAAO;QACxB,IAAI,GAAG,EAAE;YACL,WAAW,CAAC,MAAM,CAAC,IAAI,CAAC,gBAAgB,EAAE;gBACtC,OAAO,EAAE,GAAG;gBACZ,OAAO,EAAE,OAAO,IAAI,IAAI;gBACxB,QAAQ,EAAE,IAAI;aACjB,CAAC,CAAC;SACN;I
ACL,CAAC,CAAC;AACN,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./notify.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/pause.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"pause.js","sourceRoot":"","sources":["../../lib/public/pause.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb;;;GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,WAAW;IACjC,OAAO;Q
ACH,WAAW,CAAC,MAAM,GAAG,IAAI,CAAC;IAC9B,CAAC,CAAC;AACN,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./pause.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/public-utils.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"public-utils.js","sourceRoot":"","sources":["../../lib/public/public-utils.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb,IAAI,CAAC,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAA
C;AAEpC,MAAM,CAAC,OAAO,GAAG;IACb;;;;;OAKG;IACH,eAAe,EAAE,SAAS,eAAe,CAAC,OAAO,EAAE,IAAI,EAAE,GAAG;QACxD,OAAO,CAAC,IAAI,CAAC,cAAc,EAAE;YACzB,IAAI,EAAE,IAAI;YACV,GAAG,EAAE,GAAG;YACR,SAAS,EA
AE,MAAM;YACjB,KAAK,EAAE,QAAQ;SAClB,CAAC,CAAC;IACP,CAAC;IACD;;;OAGG;IACH,iBAAiB,EAAE,SAAS,eAAe,CAAC,OAAO;QAC/C,OAAO,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;IACpC,CAAC;IACD;;;;OAIG;IACH,sBAAsB,EAA
E,UAAS,OAAO,EAAE,OAAO;QAC7C,OAAO,CAAC,IAAI,CAAC,gBAAgB,EAAE,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,CAAC;IACzD,CAAC;IACD;;;;;;OAMG;IACH,WAAW,EAAE,UAAS,IAAI,EAAE,IAAI;QAC5B,IAAI,IAAI,KAAK,QAAQ,EAAE
;YACnB,OAAO,IAAI,CAAC;SACf;QAED,IAAI,IAAI,KAAK,QAAQ,EAAE;YACnB,OAAO,KAAK,CAAC;SAChB;QAED,IAAI,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QAEvB;;WAEG;QACH,IAAI,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE;
YACtB,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,MAAM,EAAE;gBAC1D,OAAO,QAAQ,CAAC,MAAM,KAAK,IAAI,CAAC;aACnC;SACJ;QAED,OAAO,KAAK,CAAC;IACjB,CAAC;CACJ,C
AAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./public-utils.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/reload.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"reload.js","sourceRoot":"","sources":["../../lib/public/reload.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb,IAAI,KAAK,GAAG,OAAO,CAAC,UAAU,CAAC,CAAC;AAChC,IAAI,W
AAW,GAAG,OAAO,CAAC,gBAAgB,CAAC,CAAC;AAC5C,IAAI,CAAC,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAAC;AACpC,IAAI,aAAa,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAAC;AACjD,IAAI,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,CAAC;AAEjC;;;
GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,OAAO;IAC7B;;;;OAIG;IACH,SAAS,iBAAiB,CAAC,IAAI;QAC3B;;;;;;;WAOG;QACH,IAAI,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE;YAClB,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CA
AC,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE;gBAClD,IAAI,IAAI,CAAC,MAAM,KAAK,IAAI,EAAE;oBACtB,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC;iBAChC;aACJ;SACJ;QAED;;;WAGG;QACH,IAAI,
OAAO,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,WAAW,EAAE;YAClD,OAAO,WAAW,CAAC,eAAe,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;SAC3D;QAED;;;WAGG;QACH,IAAI,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE;YACrB,OAAO,I
AAI,CAAC,OAAO,CAAC,UAAS,QAAQ;gBACjC,WAAW,CAAC,eAAe,CAAC,OAAO,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC;YACzD,CAAC,CAAC,CAAC;SACN;QAED;;;;;;WAMG;QACH,OAAO,WAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;IAClD,C
AAC;IAED,OAAO,iBAAiB,CAAC;AAC7B,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./reload.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/resume.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"resume.js","sourceRoot":"","sources":["../../lib/public/resume.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb;;;GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,WAAW;IACjC,OAAO
;QACH,WAAW,CAAC,MAAM,GAAG,KAAK,CAAC;IAC/B,CAAC,CAAC;AACN,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./resume.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

ERROR in ./node_modules/browser-sync/dist/public/stream.js.map 1:10
Module parse failed: Unexpected token (1:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> {"version":3,"file":"stream.js","sourceRoot":"","sources":["../../lib/public/stream.js"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAEb,IAAI,IAAI,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC;AAC3B,IAAI,U
AAU,GAAG,OAAO,CAAC,YAAY,CAAC,CAAC;AACvC,IAAI,KAAK,GAAG,OAAO,CAAC,gBAAgB,CAAC,CAAC;AAEtC;;;GAGG;AACH,MAAM,CAAC,OAAO,GAAG,UAAS,OAAO;IAC7B;;;;;OAKG;IACH,SAAS,wBAAwB,CAAC,IAAI;QAClC,IAAI,GAA
G,IAAI,IAAI,EAAE,CAAC;QAClB,IAAI,OAAO,GAAG,KAAK,CAAC;QACpB,IAAI,SAAS,GAAG,OAAO,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC;QAC5C,IAAI,MAAM,GAAG,IAAI,SAAS,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;QACjD,
IAAI,OAAO,GAAG,EAAE,CAAC;QAEjB,MAAM,CAAC,UAAU,GAAG,UAAS,IAAI,EAAE,QAAQ,EAAE,IAAI;YAC7C,IAAI,MAAM,GAAG,IAAI,CAAC;YAElB;;;;eAIG;YACH,SAAS,GAAG;gBACR,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC
,mCAAmC;gBACtD,IAAI,EAAE,CAAC;YACX,CAAC;YAED;;;eAGG;YACH,IAAI,IAAI,CAAC,KAAK,EAAE;gBACZ,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAAC,MAA
M,EAAE;oBAC1D,OAAO,GAAG,EAAE,CAAC;iBAChB;aACJ;YAED;;;eAGG;YACH,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,CAAC,OAAO,EAAE;gBAChC,KAAK,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;gBAEjC,OAAO,GAAG,IAAI,CAAC;aA
ClB;iBAAM;gBACH,kBAAkB;gBAElB,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,OAAO,EAAE;iBAClC;qBAAM;oBACH,IAAI,IAAI,CAAC,IAAI,EAAE;wBACX,OAAO,GAAG,IAAI,CAAC;wBACf,KAAK,CAAC,eAAe,CAAC,OAAO,EAAE,IAAI,
CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;wBACjD,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;qBAC1C;iBACJ;aACJ;YAED,GAAG,EAAE,CAAC;QACV,CAAC,CAAC;QAEF;;;;;WAKG;QACH,MAAM,CA
AC,MAAM,GAAG,UAAS,IAAI;YACzB,IAAI,OAAO,CAAC,MAAM,EAAE;gBAChB,KAAK,CAAC,sBAAsB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;aAClD;YAED,IAAI,EAAE,CAAC;QACX,CAAC,CAAC;QAEF,OAAO,MAAM,CAAC;IAClB,CAAC;IAED,O
AAO,wBAAwB,CAAC;AACpC,CAAC,CAAC"}
 @ ./node_modules/browser-sync/dist/public/ sync ^\.\/.*$ ./stream.js.map
 @ ./node_modules/browser-sync/dist/http-protocol.js 83:12-48
 @ ./node_modules/browser-sync/dist/server/utils.js 118:24-62
 @ ./node_modules/browser-sync/dist/browser-sync.js 512:22-62
 @ ./node_modules/browser-sync/dist/index.js 7:18-43
 @ dll renderer renderer[7]

webpack compiled with 13 errors
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

on yarn start
image

@manojVivek manojVivek mentioned this pull request Sep 9, 2022
36 tasks
@manojVivek
Copy link
Collaborator Author

It would be good to put somewhere which features have been migrated, which ones are missing and which are the priorities.

I have created an issue with the list of features here: #724

Please feel free to add/remove items in the list.

@manojVivek
Copy link
Collaborator Author

on yarn start image

This error can be ignored (by clicking close at the bottom). This happens when the URL redirects to a different URL. More info here: electron/electron#24171 (comment)

Tried a few things to suppress the error (Like adding ErrorBoundaries, catching errors from webview, etc) but no luck yet.

@manojVivek
Copy link
Collaborator Author

I am getting errors on postinstall command execution:

These errors are from browser sync and doesn't seem to be blockers, so added a workaround to suppress these and pushed a commit.

@manojVivek
Copy link
Collaborator Author

@jjavierdguezas It has reached a point where we can do beta releases as it's complete with all features marked as beta required.

I'm merging this and testing the release of beta version of app using GitHub actions. Please feel free to leave your review, and I'll address them in a future PR.

@manojVivek manojVivek merged commit 46e652e into main Oct 16, 2022
@manojVivek manojVivek deleted the desktop-app-rewrite branch October 16, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants