Add sadd_returns_boolean + sadd? method #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveitaly
requested changes
Nov 26, 2022
| class << self | ||
| attr_accessor :sadd_returns_boolean | ||
| end | ||
|
|
There was a problem hiding this comment.
This isn't needed, right? Can we remove it?
There was a problem hiding this comment.
It's needed, as it provides the way to set and read the sadd_returns_boolean value. This is used by the Redis gem to determine whether or not to display that deprecation message.
|
@iloveitaly Is there anything else you'd like me to look into for this PR? |
iloveitaly
reviewed
Dec 13, 2022
|
Thanks for the merge! Can we please get this included in a new gem release? |
|
Yes! I'll try to get to it this week. Ping me if it's not done!
… Message ID: ***@***.***>
|
|
@iloveitaly if you're busy I should be able to knock out a release today/tomorrow. |
|
Yeah I'm totally slammed so if you have time that would be great
…On Mon, Dec 19, 2022 at 9:09 AM Patrick Tulskie ***@***.***> wrote:
@iloveitaly <https://github.com/iloveitaly> if you're busy I should be
able to knock out a release today/tomorrow.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABE2R36KDXMW5QVSJ4EX2DWOCCFJANCNFSM6AAAAAASLT2IOY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Release is mostly done but rubygems is kicking me out. I'll push up the gem once @iloveitaly has a chance to take a look. |
|
I think I fixed it! Let me know if that doesn't work.
Message ID: ***@***.***>
… |
|
Thanks @iloveitaly @radar this is now in 1.10.0. Thanks for sorting this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216.