Skip to content

Commit

Permalink
✅ Exclude incompatible versions from CI matrix
Browse files Browse the repository at this point in the history
With a little effort, some of these could be made compatible, but...
it's really not worth the effort.  We'll be dropping support for older
versions from the next minor release anyway.
  • Loading branch information
nevans committed May 16, 2024
1 parent 404143e commit 64735fb
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,25 @@ jobs:
resque: "2.6"
redis: "5.2"

exclude:
# The resque 1.22 gemfile seems to be okay with ruby 3.2 and 3.3
- { resque: "1.23", ruby: "3.2" } # unknown incompatibility...
- { resque: "1.23", ruby: "3.3" } # unknown incompatibility...
- { resque: "1.24", ruby: "3.2" } # unknown incompatibility...
- { resque: "1.24", ruby: "3.3" } # unknown incompatibility...
- { resque: "1.25", ruby: "3.2" } # unknown incompatibility...
- { resque: "1.25", ruby: "3.3" } # unknown incompatibility...
- { resque: "1.26", ruby: "3.2" } # unknown incompatibility...
- { resque: "1.26", ruby: "3.3" } # unknown incompatibility...

- { resque: "2.1", ruby: "3.0" } # redis-namespace 1.7 requires ruby < 3
- { resque: "2.1", ruby: "3.1" } # redis-namespace 1.7 requires ruby < 3
- { resque: "2.1", ruby: "3.2" } # redis-namespace 1.7 requires ruby < 3
- { resque: "2.1", ruby: "3.3" } # redis-namespace 1.7 requires ruby < 3

- { resque: "2.5", ruby: "2.4" } # redis 5.0 requires ruby 2.5
- { resque: "2.6", ruby: "2.4" } # redis 5.2 requires ruby 2.6
- { resque: "2.6", ruby: "2.5" } # redis 5.2 requires ruby 2.6

services:
redis:
Expand Down

0 comments on commit 64735fb

Please sign in to comment.