Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for compatibility with redis-rb v5.0 #757

Merged
merged 5 commits into from Oct 6, 2022

Conversation

mishina2228
Copy link
Contributor

This PR fixes failing tests with redis-rb v5.0,
and also added matrix for redis-rb v4 and v5.

Here are the details:

  • Field and value for hash must be String, Integer or Float
  • Use Resque::DataStore#reconnect instead of removed Redis::Client#reconnect
  • Added matrix redis version
    • Test with redis-rb v4.x and v5.x
    • Update resque test matrix from ~> 2.2.0 to ~> 2.4.0
    • Exclude the combination of the following:
      • redis-rb v5.x with Ruby 2.4 or older
      • redis-rb v5.x with Resque 1.27.x
    • Fix resque-version in exclusions
      • They should be started with ~> .

These test cases fail with redis-rb v5.0
`Redis::Client#reconnect` has been removed from redis-rb v5.0.0.
- Test with redis-rb v4.x and v5.x
- Update resque test matrix from "~> 2.2.0" to "~> 2.4.0"
- Fix resque-version in exclusions
  - They should be started with "~> ".
@mishina2228
Copy link
Contributor Author

mishina2228 commented Sep 25, 2022

As stated at #753 (comment), some of the tests seem flaky. I will look into this a bit.

@mishina2228
Copy link
Contributor Author

OK, I found the cause of the problem.
It seems that the tests fail if data from the previous test case is still in Redis.
I made sure that flushall is executed like other test files.

@PatrickTulskie PatrickTulskie self-requested a review October 6, 2022 14:01
@PatrickTulskie
Copy link
Contributor

Having some CI/branch protection issues. Lemme get that sorted out with @iloveitaly and then I can get this into master and a new release out.

@PatrickTulskie PatrickTulskie merged commit c785771 into resque:master Oct 6, 2022
@mishina2228 mishina2228 deleted the redis-rb-5 branch October 7, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants