Fix json dump crasher with JSON 2.7.0+ #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll squash the commits before this gets merged. Just doing this work from the GitHub interface and my phone while I'm on the road. |
|
FYI, the reason for the crash is json 2.7.0 rather than Ruby 3+. |
Thank you for that. I was scratching my head trying to figure out why this wasn't a more widespread issue and doesn't affect any of the apps I'm running in prod. I don't use JSON logging with resque-scheduler so I figured that was the case. Lemme update the PR and commits with this info though. |
PatrickTulskie
force-pushed
the
json-dump-crash
branch
from
45ad2ec
to
60ce797
Compare
PatrickTulskie
changed the title
PatrickTulskie
changed the title
PatrickTulskie
force-pushed
the
json-dump-crash
branch
from
60ce797
to
cfe0183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix a crasher that primarily affects Ruby 3+ when using JSON 2.7.0 when dumping logs to JSON.
Thanks @mishina2228 for pointing out this is related to flori/json#553