-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endless loop when path contains { without paired "}" #1713
Comments
kool79
changed the title
Endless loop when path contains } { combination
Endless loop when path contains { without paired "}"
Aug 2, 2023
kool79
added a commit
to kool79/rest-assured
that referenced
this issue
Aug 2, 2023
johanhaleby
pushed a commit
that referenced
this issue
Dec 8, 2023
@kool79 I had to revert your pull request because it broke the test io.restassured.itest.java.PathParamITest#throwsIllegalArgumentExceptionWhenTooManyPathParametersAreUsed. Could you address this in your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Actual: endless loop
Expected: url is sent with properly encoded characters in path: GET http://server.com/api/product%7Bxxx
Note that character "}" is properly encoded when used in url.
Endless loop is ocurred in RequestSpecificationImp#partiallyApplyPathParams, in the while() loop.
v5.1.1
Need to exit the "while" loop if indexOfEndBracket < 0
PS> I know that path in my example contains forbidden character but it should not cause endless loop. Actually we can get URL from any sources. Currently RestAssures properly encode all forbided characters in path: ", }, etc
But fail with the "{"
The text was updated successfully, but these errors were encountered: