Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication/CertificateAuthSettings uses deprecated SSLSocket factory #621

Open
oscaritoro opened this issue Nov 30, 2015 · 9 comments
Open

Comments

@johanhaleby
Copy link
Collaborator

Would it be possible to use both? Would you like to help out?

@oscaritoro
Copy link
Author

You could probably leave in the "old" interfaces and deprecate in the rest-asured code also... it's probably wise to do so as the migration will most probably be non-backwards compatible so users will have to modify their projects to use the new interfaces. I'll see if I can set aside some time and create a PR for you.

@johanhaleby
Copy link
Collaborator

Thanks! A pull request would be awesome!

@johanhaleby
Copy link
Collaborator

@oscaritoro Could you find some time to do this soon? I'd like to make a new release asap.

@oscaritoro
Copy link
Author

Sorry but I haven't been able to find the time... When I started looking
into it I noticed that there was a lot more underlying constructs that
would also have to be brought up to par... and then my son got sick and I
had to spend a few days out of work and now I'm still catching back up with
work... given that the holidays are here, I just don't think I'll be able
to find the time to do this quickly... Sorry :(

On Fri, Dec 18, 2015 at 1:16 AM, Johan Haleby notifications@github.com
wrote:

@oscaritoro https://github.com/oscaritoro Could you find some time to
do this soon? I'd like to make a new release asap.


Reply to this email directly or view it on GitHub
#621 (comment)
.

@jhasenauer
Copy link

This is something I would like to see done. I'll look at it this week and hopefully submit a PR soon.

@johanhaleby
Copy link
Collaborator

@jhasenauer That would be of great help!

@spartanglady
Copy link

Hey Guys.. Is this already implemented. ?

@Jerbell
Copy link

Jerbell commented May 14, 2020

Long time between drinks :) This isn't a hard task - just need to switch SSLSocketFactory -> SSLConnectionSocketFactory, X509HostnameVerifier -> HostnameVerifier. I wouldn't bother using both - just switch over for a major(ish) version. The deprecated classes are quite spread out through the code - so it's a bit fiddly. I could help if you plan to do a major release some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants