New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authentication/CertificateAuthSettings uses deprecated SSLSocket factory #621
Comments
Would it be possible to use both? Would you like to help out? |
You could probably leave in the "old" interfaces and deprecate in the rest-asured code also... it's probably wise to do so as the migration will most probably be non-backwards compatible so users will have to modify their projects to use the new interfaces. I'll see if I can set aside some time and create a PR for you. |
Thanks! A pull request would be awesome! |
@oscaritoro Could you find some time to do this soon? I'd like to make a new release asap. |
Sorry but I haven't been able to find the time... When I started looking On Fri, Dec 18, 2015 at 1:16 AM, Johan Haleby notifications@github.com
|
This is something I would like to see done. I'll look at it this week and hopefully submit a PR soon. |
@jhasenauer That would be of great help! |
Hey Guys.. Is this already implemented. ? |
Long time between drinks :) This isn't a hard task - just need to switch SSLSocketFactory -> SSLConnectionSocketFactory, X509HostnameVerifier -> HostnameVerifier. I wouldn't bother using both - just switch over for a major(ish) version. The deprecated classes are quite spread out through the code - so it's a bit fiddly. I could help if you plan to do a major release some time. |
Consider moving from http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/conn/ssl/SSLSocketFactory.html to http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/conn/ssl/SSLConnectionSocketFactory.html.
The text was updated successfully, but these errors were encountered: