-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for web test client #1078
Merged
johanhaleby
merged 25 commits into
rest-assured:master
from
OlgaMaciaszek:support-for-web-test-client
Oct 11, 2018
Merged
Support for web test client #1078
johanhaleby
merged 25 commits into
rest-assured:master
from
OlgaMaciaszek:support-for-web-test-client
Oct 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WebTestClient instances.
Add `standaloneSetup()`, `given()`, `when()`, `and()` methods implementation. Start moving code that can be reused to a commons module. Start implementing `WebTesClientRequestSpecificationImpl`.
logging for WebTestClient.
to standard test formatting.
…ging tests to WebTestClient returned headers. Implement setup for logging if validation fails.
in `WebTestClientRequestLogSpecificationImpl`, add fixes to `WebTestClientRequestSpecification` and `WebTestClientRequestSenderImpl`. Add more tests for params, requests and request specification.
…ring in order to enable custom content types. Add more tests.
…tent type for URL-encoded. Add `PutTest`.
`RequestLoggingTest`. Add `QueryParamTest`.
…lity of returning responseSpec as trying to do body assertions on it would cause issues, cause the stream has already been blocked to get the byte array response.
…ode. Add license comments. Javadoc fixes.
…tory not assigned.
@johanhaleby I've filed the |
@OlgaMaciaszek Thanks a lot! Really impressive, great work! I'm so grateful for this contribution. I'll try to fix the docs as soon as a find time and then issue a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Spring WebTestClient-based RestAssured Tests.
I have tried to maintain the original API and structure as much as possible. I have extracted some things to a new, shared module in order to avoid duplication. Finally, I have added the implementation with
WebTestClient
underneath; it mostly uses the existingRestAssured
api. I have added the possibility to create router-function-based instances, requests with uri function paramters and the possibility to add consumer, however, I have not added the possibility to return aWebTestClient
response spec for the users to runWebTestClient
- style assertions, cause I have to close the body content stream in order to extract the byte[] body response content which is the base for allRestAssured
assertions, which closes the stream and users would get errors if they try to executeWebTestClient
-style body content assertions against that.