Tentative fix for #77 and #154

[Zlika]

Tentative fix for #77 and #154. The default behaviour ("Accept-Encoding: gzip,deflate") is kept to avoid breaking backward compatibility.
The only problem I see with this fix is that it uses an internal type (com.jayway.restassured.internal.http.ContentEncoding) in the public API of RequestSpecification, but this problem already exists for ObjectMapperType. Maybe this type could be moved outside the internal package ? (I would like to avoid creating a new public "ContentEncoding" that would be a mere copy-paste of the original one)

[johanhaleby]

Thanks for helping out! I have some comments though at the google code
website at issue 154.

On Tue, Jul 2, 2013 at 3:17 PM, Zlika notifications@github.com wrote:

Tentative fix for #77 and #154. The default behaviour ("Accept-Encoding:
gzip,deflate") is kept to avoid breaking backward compatibility.
The only problem I see with this fix is that it uses an internal type
(com.jayway.restassured.internal.http.ContentEncoding) in the public API of
RequestSpecification, but this problem already exists for ObjectMapperType.
Maybe this type could be moved outside the internal package ? (I would like
to avoid creating a new public "ContentEncoding" that would be a mere

copy-paste of the original one)

You can merge this Pull Request by running

git pull https://github.com/Zlika/rest-assured master

Or view, comment on, or merge it at:

#17
Commit Summary

• Tentative fix for useRelaxedHTTPSValidation does not seem to work with Java 6 (JDK) #77 and Support for custom HTTP methods #154. The only problem I see with this fix
  is that it uses an internal type
  (com.jayway.restassured.internal.http.ContentEncoding) in the public API :
  could this type be moved outside the internal package ?

File Changes

• M
  rest-assured/src/main/groovy/com/jayway/restassured/internal/RequestSpecificationImpl.groovyhttps://github.com/Tentative fix for #77 and #154 #17/files#diff-0(15)
• M
  rest-assured/src/main/java/com/jayway/restassured/specification/RequestSpecification.javahttps://github.com/Tentative fix for #77 and #154 #17/files#diff-1(12)

Patch Links:

• https://github.com/jayway/rest-assured/pull/17.patch
• https://github.com/jayway/rest-assured/pull/17.diff

[buildhive]

Jayway » rest-assured #79 SUCCESS
This pull request looks good
(what's this?)

[Zlika]

By the way, I saw that there were very few unit tests on rest-assured, and nothing is setup in the Maven build to allow "real world" REST tests. On one of my projects I use Arquillian to automate REST tests (with rest-assured). It could be easily feasible to write a small JEE REST application and use Arquillian to automate rest-assured tests. If you are interested I can propose a pull request on the subject when I have enough time.

[johanhaleby]

Thanks a lot for helping out! I've accepted that patch but I'll probably update it a little bit.

There are actually quite a few integration tests for Rest Assured, they're located in the examples/rest-assured-itest-java project! :)

[Zlika]

Oups, if I had seen these IT tests I would have added others for this new feature instead of using the test suite of my project at work.
Feel free to update the patch, I will not be upset :-)

[karthik008]

Hi I am still getting error stating that "java.util.zip.ZipException: incorrect header check",Iam using Rest assured 3.0

Response r = io.restassured.RestAssured.given().headers("content-type","application/json").headers("Accept","application/json").contentType(ContentType.JSON).body(updateBody).when().post("http://Common.domain.com/api/api/TestItem/678566/3.3.90.57/test/").then().extract().response();