Replace deprecatet HttpEntity.consume with EntityUtils.consume #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, in certain cases (at least in the integration tests), EntityUtils is not available. Have to check this. |
|
Thanks for the pull request. In what scenarios are |
|
Turned out it was an error on my side, I missed out an import that wasn't added automatically by Eclipse (I'm not doing much groovy and thus my env isn't really prepared for it) which broke some integrationtests. With ec728f6, those concerns are gone. With the dependencies as they are right now, I do not see a problem |
johanhaleby
added a commit
that referenced
this pull request
Feb 3, 2016
Replace deprecatet HttpEntity.consume with EntityUtils.consume
|
Oh OK! Great I'll bring it on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #633