Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestMetadata::InstantiateChildMetadata method added #233

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented May 30, 2022

jgalan Ok: 94

Simply adding a method that will help to retrieve child TRestMetadata XML elements.

This will allow to keep TinyXml into the domain of TRestMetadata.

We can use that method to make the task of reading a child metadata element easier. I.e. I use inside TRestAxionXrayWindow as:

    if (fMask) {
        delete fMask;
        fMask = nullptr;
    }
    fMask = (TRestPatternMask*)this->GetChildMetadata("Mask", "mask");

@jgalan jgalan requested review from juanangp and nkx111 May 30, 2022 16:04
@jgalan jgalan marked this pull request as ready for review May 30, 2022 16:04
@jgalan jgalan requested a review from lobis May 30, 2022 17:45
@jgalan
Copy link
Member Author

jgalan commented Jun 7, 2022

Needs review @nkx111 @lobis @juanangp

@jgalan jgalan changed the title TRestMetadata::GetChildMetadata method added TRestMetadata::InstantiateChildMetadata method added Jun 9, 2022
@jgalan jgalan merged commit 05e6081 into master Jun 9, 2022
@jgalan jgalan deleted the jgalan_metadata_child branch June 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants