pull-submodules.py minor update

[jgalan]

I think we had to add the following patch in order to get the latest remote. If not, the local master branch was not always synced. Recently remarked by @KonradAltenmueller

[jgalan]

@lobis @juanangp Any idea why restG4 simulation is failing here? It says something about ibstdc++.so.6 not being found.

[juanangp]

@lobis @juanangp Any idea why restG4 simulation is failing here? It says something about ibstdc++.so.6 not being found.

This branch is up-to-date with master? It is strange that is giving this error

[jgalan]

Ok, I relaunched the pipeline. A different error is coming out. Since the update on this PR is just that pulls the latest, perhaps we were not testing against the latest master?

https://gitlab.cern.ch/rest-for-physics/framework/-/commit/0e9eeb9e2458d6f477d622aa65356994f2465846/pipelines?ref=pull_modules_minor_fix

It is the PandaX-III topology failing now @nkx

[juanangp]

Ok, I relaunched the pipeline. A different error is coming out. Since the update on this PR is just that pulls the latest, perhaps we were not testing against the latest master?

https://gitlab.cern.ch/rest-for-physics/framework/-/commit/0e9eeb9e2458d6f477d622aa65356994f2465846/pipelines?ref=pull_modules_minor_fix

It is the PandaX-III topology failing now @nkx

That's weird, perhaps some changes in the docker image @lobis

[lobis]

Ok, I relaunched the pipeline. A different error is coming out. Since the update on this PR is just that pulls the latest, perhaps we were not testing against the latest master?
https://gitlab.cern.ch/rest-for-physics/framework/-/commit/0e9eeb9e2458d6f477d622aa65356994f2465846/pipelines?ref=pull_modules_minor_fix
It is the PandaX-III topology failing now @nkx

That's weird, perhaps some changes in the docker image @lobis

No, I made changes to the rest-for-physics image a few days ago but they are reverted, the image is the exact same as before and pipeline in other branches is passing so I don't think its the image.

[juanangp]

I think the issue is because of this PR #233 which is already merged

2022-06-09T09:11:26.3459062Z /__w/framework/framework/framework/source/libraries/axion/src/TRestAxionXrayWindow.cxx:313:38: error: 'class TRestAxionXrayWindow' has no member named 'InstantiateChildMetadata'
2022-06-09T09:11:26.3460140Z   313 |     fMask = (TRestPatternMask*)this->InstantiateChildMetadata("Mask", "mask");
2022-06-09T09:11:26.3460491Z       |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
2022-06-09T09:11:26.5803304Z make[2]: Leaving directory '/__w/framework/framework/framework/build'
2022-06-09T09:11:26.6202534Z [ 57%] Built target RestTrack
2022-06-09T09:11:26.6318561Z make[2]: Entering directory '/__w/framework/framework/framework/build'
2022-06-09T09:11:26.6910184Z [ 57%] generating: /__w/framework/framework/framework/build/rootdict/CINT_TRestRawZeroSuppresionProcess.cxx with /__w/framework/framework/framework/source/libraries/legacy/inc/TRestRawZeroSuppresionProcess.h;/__w/framework/framework/framework/build/rootdict/TRestRawZeroSuppresionProcess_Linkdef.h
2022-06-09T09:11:26.9816357Z make[2]: *** [source/libraries/axion/CMakeFiles/RestAxion.dir/build.make:410: source/libraries/axion/CMakeFiles/RestAxion.dir/src/TRestAxionXrayWindow.cxx.o] Error 1

I am working on implementing a pipeline in github to avoid this kind of issues, in fact this error comes from the github workflow that I am working on.

[jgalan]

I think the issue is because of this PR #233 which is already merged

2022-06-09T09:11:26.3459062Z /__w/framework/framework/framework/source/libraries/axion/src/TRestAxionXrayWindow.cxx:313:38: error: 'class TRestAxionXrayWindow' has no member named 'InstantiateChildMetadata'
2022-06-09T09:11:26.3460140Z   313 |     fMask = (TRestPatternMask*)this->InstantiateChildMetadata("Mask", "mask");
2022-06-09T09:11:26.3460491Z       |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
2022-06-09T09:11:26.5803304Z make[2]: Leaving directory '/__w/framework/framework/framework/build'
2022-06-09T09:11:26.6202534Z [ 57%] Built target RestTrack
2022-06-09T09:11:26.6318561Z make[2]: Entering directory '/__w/framework/framework/framework/build'
2022-06-09T09:11:26.6910184Z [ 57%] generating: /__w/framework/framework/framework/build/rootdict/CINT_TRestRawZeroSuppresionProcess.cxx with /__w/framework/framework/framework/source/libraries/legacy/inc/TRestRawZeroSuppresionProcess.h;/__w/framework/framework/framework/build/rootdict/TRestRawZeroSuppresionProcess_Linkdef.h
2022-06-09T09:11:26.9816357Z make[2]: *** [source/libraries/axion/CMakeFiles/RestAxion.dir/build.make:410: source/libraries/axion/CMakeFiles/RestAxion.dir/src/TRestAxionXrayWindow.cxx.o] Error 1

I am working on implementing a pipeline in github to avoid this kind of issues, in fact this error comes from the github workflow that I am working on.

I dont think thats connected with the PandaX-III topology error. I merged both, the framework and axionlib implementations (related to ChildMetadata) at the same time.

I mean, the error you are showing should not appear since this was merged to master here : rest-for-physics/axionlib#26

At the same time. So, perhaps pull-submodules.py was not pulling the latest master, which is what it is solving this PR?