-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestEnv support for mock networking #1264
Conversation
Test Results 92 files - 25 92 suites - 25 4m 4s ⏱️ - 4m 5s Results for commit 61c23e0. ± Comparison against base commit d1d9f87. This pull request removes 73 and adds 44 tests. Note that renamed tests count towards both.
This pull request removes 5 skipped tests and adds 15 skipped tests. Note that renamed tests count towards both.
This pull request skips 10 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @AhmedSoliman. The changes look good to me. I had one question concerning hooking the MetadataManager
up with the network layer. +1 for merging.
In fact, let me park this a little bit. TestEnv needs a slight redesign to follow the builder pattern instead. |
Reworked the design. Ready again for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 for merging.
TestEnv support for mock networking
Stack created with Sapling. Best reviewed with ReviewStack.