[4/n] Partial refactor of worker and admin role configs #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2024
Closed
AhmedSoliman
changed the title
AhmedSoliman
force-pushed
the
pr1328
branch
4 times, most recently
from
b2fb909
to
dd47f77
Compare
Test Results 92 files ±0 92 suites ±0 10m 20s ⏱️ -5s For more details on these failures, see this check. Results for commit dd47f77. ± Comparison against base commit 1a47f34. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tillrohrmann
approved these changes
Mar 27, 2024
crates/node/src/options.rs
Outdated
|
|
||
| /// todo: remove. |
There was a problem hiding this comment.
I think admin_address is no longer used. So feel free to just remove it.
| @@ -46,6 +46,14 @@ impl ServiceClient { | |||
| pub(crate) fn new(http: HttpClient, lambda: LambdaClient) -> Self { | |||
| Self { http, lambda } | |||
| } | |||
|
|
|||
| pub fn from_options(options: Options, assume_role_cache_mode: AssumeRoleCacheMode) -> Self { | |||
| let (http, lambda) = options.dissolve(); | |||
There was a problem hiding this comment.
Nice, learned again something :-)
Closed
More re-org and cleanup. We need to move away from the `Options::build()` style: - We should treat configuration as data-only structures that won't be consumed on service creation - We pave the way for updateable config, components will own a "projection" to the config in the future instead of consuming it on startup This is not the final structure, many changes are transitional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4/n] Partial refactor of worker and admin role configs
More re-org and cleanup. We need to move away from the
Options::build()style:This is not the final structure, many changes are transitional