Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record nanos instead of millis for bifrost record creation time #1544

Merged
merged 1 commit into from
May 24, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented May 22, 2024

Copy link

github-actions bot commented May 22, 2024

Test Results

 99 files  ±0   99 suites  ±0   8m 16s ⏱️ +31s
 83 tests ±0   83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
212 runs  ±0  212 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a21f9a0. ± Comparison against base commit c768db1.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman marked this pull request as ready for review May 22, 2024 14:51
@AhmedSoliman AhmedSoliman force-pushed the pr1544 branch 2 times, most recently from f6c140e to 030f3b7 Compare May 23, 2024 09:04
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

// it's ~580 years from unix epoch until u64 wouldn't become sufficient to store nanos.
let t = NanosSinceEpoch::now().as_u64();
assert!(t < u64::MAX);
println!("{:?}", t);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the println needed for anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think so, it's just there to match the existing test. Maybe it was to avoid compiler optimizing it out?

@AhmedSoliman AhmedSoliman merged commit a21f9a0 into main May 24, 2024
11 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1544 branch May 24, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants