Journal Entries model #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 239d3f2 git-subtree-dir: src/service_protocol/service-protocol git-subtree-split: 239d3f29a1f7ce913cea9a14924249b01b82ccc0
…ce_protocol/service-protocol'
slinkydeveloper
commented
Feb 6, 2023
src/service_protocol/src/lib.rs
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| pub mod codec; | |||
|
|
|||
| pub mod pb { | |||
| mod pb { | |||
There was a problem hiding this comment.
Actually there is a reason, testing 😄
But perhaps we could have a feature flag that makes this mod public only when feature "testing" or "mocks" is compiled. Can also do it when we need it, and not prematurely
There was a problem hiding this comment.
Changed my mind here, we need this public
slinkydeveloper
force-pushed
the
issues/64
branch
from
7eaca9b
to
17e9b17
Compare
Merged
tillrohrmann
reviewed
Feb 7, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. I think the changes look good to me. I like how we can decode a pb message on demand into the journal model.
I had some comments/questions mostly of minor nature. I guess the main question is whether we want to expose the codec in our RawEntry for the time being or not. My gut feeling is that we might be able to do w/o it until we have a real need for it.
tillrohrmann
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Thanks for updating this PR @slinkydeveloper. LGTM. +1 for merging.
Introduce service_protocol crate to host structs from service-protocol protobufs Implement the entries codec Add install protoc action
slinkydeveloper
force-pushed
the
issues/64
branch
from
1869fa8
to
f69b132
Compare
slinkydeveloper
added a commit
to slinkydeveloper/restate
that referenced
this pull request
Mar 21, 2024
…8d559..61ae44b2 61ae44b2 Update documentation on error codes (restatedev#77) 576a1b26 Add HandlerType. Fix restatedev#1092 (restatedev#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (restatedev#74) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 61ae44b2175c2a54c2d7a138a3368df17f389ebb
slinkydeveloper
added a commit
to slinkydeveloper/restate
that referenced
this pull request
Mar 26, 2024
…8d559..29b28f98 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (restatedev#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (restatedev#79) 61ae44b2 Update documentation on error codes (restatedev#77) 576a1b26 Add HandlerType. Fix restatedev#1092 (restatedev#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (restatedev#74) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5
slinkydeveloper
added a commit
to slinkydeveloper/restate
that referenced
this pull request
Mar 26, 2024
…8d559..29b28f98 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (restatedev#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (restatedev#79) 61ae44b2 Update documentation on error codes (restatedev#77) 576a1b26 Add HandlerType. Fix restatedev#1092 (restatedev#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (restatedev#74) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5
slinkydeveloper
added a commit
that referenced
this pull request
Mar 26, 2024
…8d559..29b28f98 29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80) 26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79) 61ae44b2 Update documentation on error codes (#77) 576a1b26 Add HandlerType. Fix #1092 (#76) 0624d092 Payload schema for input and output. This provides basic format awareness. (#74) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64
This PR:
journalmodule, with definition of theEntrymodels and theRawEntryservice_protocolcrate, containing the protobuf from service-protocol repo and the "codec" code to materialize entries